Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether interpreter changed and type (#123) #418

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

dpalmasan
Copy link
Contributor

This is an attempt to fix #123

The steps are the following

  • Check virtualenv interpreter
  • Check current interpreter
  • If there is a match, do nothing. If they are different, recreate
  • Check if the type of interpreter remains the same.

Not sure, but for the last case I made an assertion.

@dpalmasan dpalmasan force-pushed the interpreter-changed branch 4 times, most recently from 57e6590 to 3f94d57 Compare April 10, 2021 23:08
@dpalmasan dpalmasan force-pushed the interpreter-changed branch from 3f94d57 to d7ff39c Compare April 10, 2021 23:27
@theacodes theacodes merged commit a67c9a2 into wntrblm:main Apr 24, 2021
@theacodes
Copy link
Collaborator

Thank you!

@cjolowicz
Copy link
Collaborator

This caused a regression, see #424.

@dpalmasan
Copy link
Contributor Author

Thanks, gonna check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

reuse_existing should check the interpreter
3 participants