Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve post-onboarding: Remove the word "Paid" from the plugin #2672

Merged

Remove 'Paid' from ads creation

d38b1ec
Select commit
Loading
Failed to load commit list.
Merged

Improve post-onboarding: Remove the word "Paid" from the plugin #2672

Remove 'Paid' from ads creation
d38b1ec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 11, 2024 in 0s

65.5% (+1.8%) compared to 2c3f089

View this Pull Request on Codecov

65.5% (+1.8%) compared to 2c3f089

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.5%. Comparing base (2c3f089) to head (d38b1ec).

Files with missing lines Patch % Lines
...src/components/paid-ads/asset-group/asset-group.js 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                           @@
##             feature/2460-google-ads-value-prop   #2672      +/-   ##
=======================================================================
+ Coverage                                  63.6%   65.5%    +1.8%     
- Complexity                                    0    4589    +4589     
=======================================================================
  Files                                       332     805     +473     
  Lines                                      5210   24401   +19191     
  Branches                                   1265    1265              
=======================================================================
+ Hits                                       3315   15975   +12660     
- Misses                                     1718    8249    +6531     
  Partials                                    177     177              
Files with missing lines Coverage Δ
...rc/components/paid-ads/add-paid-campaign-button.js 73.3% <100.0%> (ø)
...c/components/paid-ads/ads-campaign/ads-campaign.js 0.0% <ø> (ø)
...dashboard/campaign-creation-success-guide/index.js 71.4% <ø> (ø)
js/src/pages/create-paid-ads-campaign/index.js 10.0% <ø> (ø)
js/src/pages/edit-paid-ads-campaign/index.js 8.6% <ø> (ø)
...src/product-feed/submission-success-guide/index.js 65.2% <ø> (ø)
js/src/setup-ads/ads-stepper/index.js 83.3% <ø> (ø)
js/src/setup-ads/ads-stepper/setup-paid-ads.js 62.1% <ø> (ø)
...src/components/paid-ads/asset-group/asset-group.js 4.4% <0.0%> (ø)

... and 473 files with indirect coverage changes