Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline onboarding, post-onboarding and campaign setup #2682

Merged
merged 1,058 commits into from
Nov 25, 2024
Merged

Streamline onboarding, post-onboarding and campaign setup #2682

merged 1,058 commits into from
Nov 25, 2024

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Nov 20, 2024 •
edited
Loading

Changes proposed in this Pull Request:

This PR gathers all changes from the following feature PRs for final testing and to be merged together into develop.

Additional fix

📌 Checklist before merging

joemcgill and others added 30 commits October 31, 2024 15:24
@joemcgill
Remove unused components
1f18092
@joemcgill
Remove phone account card format
bfcc39b
@joemcgill
Remvove unused useCountryCallingCodeOptions
d2b2a38
@kt-12 @eason9487
Update js/src/dashboard/summary-section/paid-features/free-ad-credit.js
cfa279c 
adding fires info

Co-authored-by: Eason <eason.su.tw@gmail.com>
@kt-12 @eason9487
Update js/src/dashboard/summary-section/paid-features/free-ad-credit.js
96e4162 
fix context

Co-authored-by: Eason <eason.su.tw@gmail.com>
@kt-12
remove usage of sections, fix styling
d5d1d2f
@kt-12
Merge branch 'feature/2538-performance-card-sep' of https://github.co…
e4fa585 
…m/woocommerce/google-listings-and-ads into feature/2538-performance-card-sep
@kt-12
remove margin
d043e81
@kt-12
seperate file for paid-features test
b77f18e
@kt-12
fix button name
cd7ec9f
@kt-12
update variable names and cleanup
6fe5003
@kt-12
cleanup
51d5187
@kt-12
Merge branch 'feature/2460-google-ads-value-prop' into feature/2538-p…
ccc7edc 
…erformance-card-sep
@kt-12
check when ads complete is set
2d77db8
@kt-12
change variable name
0fcba0f
@kt-12
avoide flakyness
38318b2
@asvinb
Address CR feedback.
17e7c84
@joemcgill
Streamline StoreAddressCard states and display
a49f43f
@asvinb
Fix linting errors.
1e0ed3b
@joemcgill
Resolve store address before showing the card
f76a955
@joemcgill
Improve updateGoogleMCContactInformation resolution
a9f5530
@joemcgill
Merge pull request #2661 from woocommerce/update/2602-sync-mc-address…
a98a698 
…-settings

2602: Simplify address syncing in settings and remove phone info
@joemcgill
Check MC address setup when getting setup status and remove phone ver…
7e87761 
…ification
@joemcgill
Fix MerchantCenterServiceTests tests
852dfde
@asvinb
Add MerchantCenterAccountInfoCard component.
0e15813
@asvinb
Fix linting errors.
4e201c1
@kt-12
change variable name
2297982
@asvinb
Remove unused component.
65e6854
@kt-12
remove additional assignement
f8f9c4a
@asvinb
Reorder imports.
4b777bc
@eason9487
Fix E2E testing for step 2 of the onboarding.
69fc117
@eason9487
Remove unnecessary mocks for the E2E testing from step 2 of the onboa…
6f93f78 
…rding.
@eason9487
Rename the CSS class name and remove unused style for the section of …
cc2440a 
…Google Merchant Center disclaimer.

Address: #2585 (comment)
@eason9487
Rename ConnectAdsFooter to ConnectExistingAccountActions for bett…
3e49942 
…er consistency.
@eason9487
Adjust exports and imports for better consistency and control of comp…
b763438 
…onent exposure.
@eason9487
Avoid flaky E2E testing for the "Validate budget percent" test cases …
e2fafdd 
…in step 3 of the onboarding.
@eason9487
Avoid API errors during E2E testing for the onboarding.
0e50835
@eason9487
Remove unused mocking methods from E2E testing.
1774b2f
@eason9487
Merge pull request #2634 from woocommerce/feature/2509-consolidate-go…
42335a1 
…ogle-account-cards

Feature: Consolidate Google accounts setup during onboarding
@eason9487
Merge branch 'feature/2458-2459-2460-2509' into feature/2460-google-a…
37dacee 
…ds-value-prop
@eason9487
Merge pull request #2635 from woocommerce/feature/2460-google-ads-val…
32adc37 
…ue-prop

Feature: Improve post-onboarding
@eason9487
Rename files and adjust JSDoc for better consistency.
087e654
@eason9487
Remove an unnecessary mocked value from the claim-account-button.test…
214377a 
….js file.
@eason9487
Revert unnecessary code changes.
b1998c9
@eason9487
Merge branch 'develop' into feature/2458-2459-2460-2509
f252968
@eason9487
Add the onDisconnected callback to the DisconnectAccount and `Con…
eff6271 
…nectExistingAccountActions` within Google Ads Account setup components.
@eason9487
Reset the account ID state in ConnectExistingAccount after account …
a686290 
…is disconnected to avoid connecting to an invalid ID.
@eason9487 eason9487 mentioned this pull request Nov 22, 2024
Merged
@eason9487
Copy link
Member Author

During overall testing, found an issue that it may try to connect to an unclaimed and disconnected account ID. Created PR #2688 to fix it.

mikkamp and others added 8 commits November 22, 2024 12:54
@mikkamp
Explicitly go to login page
ed1bc62
@mikkamp
Revert explicitly go to login page
8c1a9a5 
This reverts commit ed1bc62.
@eason9487
Merge branch 'develop' into feature/2458-2459-2460-2509
8d0e378
@eason9487
Merge branch 'feature/2458-2459-2460-2509' into fix/connect-to-invali…
b8587e6 
…d-ads-id
@eason9487
Merge pull request #2688 from woocommerce/fix/connect-to-invalid-ads-id
f2c732b 
Consolidate accounts onboarding: Prevent Google Ads account setup from trying to connect to an unclaimed and disconnected account ID
@eason9487
Revert "Temporarily run E2E testing on GitHub Actions for the `featur…
3a396e8 
…e/2458-2459-2460-2509` branch."

This reverts commit e80472a.
@eason9487
Revert "Temporarily extend the build zip retention days on GitHub Act…
70a088a 
…ions."

This reverts commit 08cec68.
@eason9487
Update src/Tracking/README.md.
6c15833
@eason9487 eason9487 self-assigned this Nov 25, 2024
@eason9487 eason9487 merged commit 4173854 into develop Nov 25, 2024
15 checks passed
@eason9487 eason9487 deleted the feature/2458-2459-2460-2509 branch November 25, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eason9487 eason9487

Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eason9487 @joemcgill @kt-12 @asvinb @mikkamp