Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Icon + text scaling on Mini Cart and My Account block #8128

Closed
Tracked by #8556
vivialice opened this issue Jan 9, 2023 · 1 comment · Fixed by #8594
Closed
Tracked by #8556

Icon + text scaling on Mini Cart and My Account block #8128

vivialice opened this issue Jan 9, 2023 · 1 comment · Fixed by #8594
Assignees
Labels
block: mini-cart Issues related to the Mini-Cart block. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@vivialice
Copy link

Hey folks! On the back of a chat I had with @danielwrobert, I wanted to highlight a visual inconsistency I noticed with text + icon scaling controls.

View example, Customer Account and Mini Cart blocks both set to Typography scale Small:
Screenshot 2023-01-09 at 15 32 41
Screenshot 2023-01-09 at 15 39 01

We came to the decision that for now, we will maintain scaling the icon alongside the text using the typography settings. However, I have noticed when the two blocks are side-by-side, the two don't look like they are using the same scale setting.

Could we check what the settings are here and match the two? Eventually, this will also apply to the search icon scaling.

  • The mini cart icon looks slightly too big compared to the customer account icon
  • In the screenshot above, it looks like we should scale the customer account icon to visually be balanced with the mini cart icon.

Since we are keeping the settings simple, the defaults should work together well visually without having to edit the two differently. I'm including some real-world examples of where we should be aiming towards:

01
Screenshot 2023-01-09 at 16 08 26

02
Screenshot 2023-01-09 at 16 08 40

03
Screenshot 2023-01-09 at 16 08 55

04
Screenshot 2023-01-09 at 16 09 06

@vivialice vivialice added block: mini-cart Issues related to the Mini-Cart block. ▫️ pattern: headers labels Jan 9, 2023
@kmanijak kmanijak added the type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Jan 9, 2023
@Aljullu
Copy link
Contributor

Aljullu commented Feb 27, 2023

When working on this, we should keep an eye on how any changes we introduce impact existing stores which are already making use of these blocks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: mini-cart Issues related to the Mini-Cart block. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants