This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Make the customer account icon bigger to match the mini-cart one #8594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
focus: global styles
|
Hi @vivialice, we have increased the size of the |
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +133 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
albarin
added
the
needs: design
albarin
force-pushed
the
update/8128-account-icon-size
branch
from
6982247
to
9d4e57d
Compare
|
@Aljullu could you have a look at this approach to increase the icon size on new blocks only? |
Aljullu
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
That's a really clever approach, I like it! I did some testing and it worked flawlessly on my end: there weren't changes in the block if it was already in the template, but when adding a new one, the sizes matched the Mini Cart block. 👏
I left one small suggestion below about the class name. Besides that, I would also add some explanation somewhere in the code (maybe when you register the variation) to explain the approach.
Even though the PR is a draft, I'm pre-approving, but happy to take another look if you want. 🙂
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
Aljullu
added a commit
that referenced
this pull request
Mar 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to increase the size of the
Customer accounticon to make it more similar to theMini cartone.Fixes #8128
Testing
Check the icon size
Customer accountandMini-cartblocks next to the menu, to look like this 👇Customer accounticon is bigger than before and matches theMini carticon size.Check the icon size of existing blocks does not change
trunk.Customer accountblock, and save.update/8128-account-icon-size).Customer accountblock and save.WooCommerce Visibility
Changelog