This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Product Query] Add support for the Filter Products By Stock block #7251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocks into fix/product-query-update
…ocks into add/price_filter_support
Product Query - Add support for the Filter By Price Block
Product Query - Add support for the Filter By Attributes block
…erce/woocommerce-blocks into add/price_filter_support
…erce/woocommerce-blocks into add/attribute_filter_support
…commerce/woocommerce-blocks into add/attribute_filter_support
…ocks into add/attribute_filter_support
…ocks into add/attribute_filter_support
Product Query - Add support for the Filter By Stock Block
gigitux
added
skip-changelog
rubikuserbot
requested review from
a team and
tjcafferkey
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
|
Size Change: 0 B Total Size: 999 kB ℹ️ View Unchanged
|
5 tasks
gigitux
changed the title
14 tasks
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label - otherwise it will automatically be closed after 10 days. |
github-actions
bot
added
the
status: stale
gigitux
removed
the
status: stale
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
gigitux
removed
the
status: stale
…ocks into add/stock_filter_support
…erce/woocommerce-blocks into add/stock_filter_support
gigitux
force-pushed
the
add/stock_filter_support
branch
from
e3cd271 to
027ab12
Compare
Aljullu
approved these changes
Nov 1, 2022
src/BlockTypes/StockFilter.php
Outdated
| protected $block_name = 'stock-filter'; | ||
| protected $block_name = 'stock-filter'; | ||
| const STOCK_STATUS_QUERY_VAR = 'filter_stock_status'; | ||
| const STOCK_STATUS_QUERY_VAR_VALUES = array( 'instock', 'outofstock', 'onbackorder' ); |
There was a problem hiding this comment.
Should we use the stock statuses returned by wc_get_product_stock_status_options() instead of hardcoding them? This way this will be compatible with any extension hooking into the woocommerce_product_stock_status_options filter.
There was a problem hiding this comment.
Good point! I addressed the feedback with d23d6a0.
…ocks into add/stock_filter_support
Script Dependencies ReportThe
This comment was automatically generated by the |
98 tasks
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
…oocommerce#7251) * Product Query: Fix pagination issue * Product Query - Add support for the Filter By Price Block woocommerce#6790 Product Query - Add support for the Filter By Price Block * fix query relation * fix on sale query * Product Query - Add support for the Filter By Attributes block woocommerce#6790 Product Query - Add support for the Filter By Attributes block * fix bugged pagination and on-sale filter after refactor * address feedback * Product Query - Add support for the Filter By Stock Block woocommerce#6790 Product Query - Add support for the Filter By Stock Block * address feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Filter By Stock block. This PR is blocked by #7186.
#6790
Screenshots
Screen.Capture.on.2022-09-29.at.14-38-33.mov
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog