This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Product Query] Fix filter block data counter #7257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocks into fix/product-query-update
…ocks into add/price_filter_support
Product Query - Add support for the Filter By Price Block
Product Query - Add support for the Filter By Attributes block
…erce/woocommerce-blocks into add/price_filter_support
…erce/woocommerce-blocks into add/attribute_filter_support
…commerce/woocommerce-blocks into add/attribute_filter_support
…ocks into add/attribute_filter_support
…ocks into add/attribute_filter_support
Product Query - Add support for the Filter By Stock Block
…e variation #7245 fix filter blocks: the data (e.g: max price or stock-status) match the variation
gigitux
added
skip-changelog
|
The release ZIP for this PR is accessible via: |
|
Size Change: +580 B (0%) Total Size: 1000 kB
ℹ️ View Unchanged
|
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label - otherwise it will automatically be closed after 10 days. |
github-actions
bot
added
the
status: stale
sunyatasattva
suggested changes
Oct 12, 2022
10 tasks
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
gigitux
removed
the
status: stale
|
@gigitux Please let me know when the feedback on this is also addressed. |
…ocks into add/stock_filter_support
…erce/woocommerce-blocks into add/stock_filter_support
…erce/woocommerce-blocks into fix/filter_display_data
gigitux
force-pushed
the
fix/filter_display_data
branch
from
064d814 to
c4a46c3
Compare
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
sunyatasattva
approved these changes
Oct 27, 2022
…ocks into fix/filter_display_data
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* Product Query: Fix pagination issue * Product Query - Add support for the Filter By Price Block woocommerce#6790 Product Query - Add support for the Filter By Price Block * fix query relation * fix on sale query * Product Query - Add support for the Filter By Attributes block woocommerce#6790 Product Query - Add support for the Filter By Attributes block * fix bugged pagination and on-sale filter after refactor * address feedback * Product Query - Add support for the Filter By Stock Block woocommerce#6790 Product Query - Add support for the Filter By Stock Block * Fix filter blocks: the data (e.g: max price or stock-status) match the variation woocommerce#7245 fix filter blocks: the data (e.g: max price or stock-status) match the variation * disable phcs rules on top of the file * replace parameter name * fix eslint error
This was referenced Jul 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked by #7251 #7186.
If you want to see only the code related to this PR, please check the commit b8bf17e
This PR is an attempt to allow the filter blocks to render the right data when a variation is used.
For example when on the page there is the On Sale Products variation:
Technical details
The backend does a query to the database to retrieve all the product ids reading the attributes used by the specific variation. The function is:
get_products_ids_by_attributes.Technical issue
With this implementation, we can't support different Product Query blocks on the same page. Also, not sure how it works with hydration :(
Fixes #7245
Accessibility
prefers-reduced-motionOther Checks
Screenshots
The data in the first image are wrong because:
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog