This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
[Experimental] Mini Cart Icon Control via theme.json.
#7491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor and/or abstract this to an external template, if...Refactor and/or abstract this to an external template, if that makes more sense.
woocommerce-blocks/src/BlockTypes/MiniCart.php Lines 399 to 410 in 68cde69 🚀 This comment was generated by the automations bot based on a
|
Determine if we need to update the inserter icon.Determine if we need to update the inserter icon. If so, we can abstract this out elsewhere because it is repeated in the block.
woocommerce-blocks/assets/js/blocks/mini-cart/index.tsx Lines 18 to 29 in 68cde69 🚀 This comment was generated by the automations bot based on a
|
|
The release ZIP for this PR is accessible via: |
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
|
Size Change: +1.9 kB (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
Allow for a set of options for the Mini Cart icon that can be controlled via the theme.json file.
Note: We are currently using a Switch case in the main Mini Cart file. It may be nice, as a follow-up task, to refactor a little bit and abstract some of that template logic out.
It was noted at the meetup that, by changing the inserter icon, we run the risk of making it more confusing for the user when looking for the block in the editor. They are likely accustomed to seeing the icon as it is and would look for that familiar item when trying to add the block.
danielwrobert
force-pushed
the
try/minicart-themejson-icon
branch
from
68cde69
to
52a1fb4
Compare
TypeScript Errors ReportFiles with errors: 448 🎉 🎉 This PR does not introduce new TS errors. |
github-actions
bot
removed
the
status: stale
danielwrobert
added
type: enhancement
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
github-actions
bot
removed
the
status: stale
|
Related to this issue #6868 |
|
This PR (as noted in the title) was more of an experiment to be served as a reference point, should we decide to pursue this route in the future. I am going to go ahead and close it out now, as it can still serve it's purpose as a reference while not being open. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental PR that allows control over the Mini Cart Icon via a theme's
theme.jsonfile.Test Plan
npm start.settingsproperty in thetheme.jsonfile:iconsetting fromminiCartBaskettominiCartBagand confirm that the Mini Cart block now uses a bag icon.Note: This current implementation also updates the icon for the block in the inserter. We likely want to keep this icon the same, as it can potentially lead to confusion for what a user is looking for when adding a block in the editor. I've left it in here for the sake of experimentation, however.
To Do
settings/block/customor if it would be better to add a separate setting outside ofsettings.