This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Mini-Cart: prevent 'Mini-Cart in cart and checkout pages' toggle from showing up in the post/page editor #9442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +5 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
Aljullu
force-pushed
the
fix/9428-prevent-pages-toggle-to-appear-in-post-editor
branch
from
357a571 to
7c79ea0
Compare
… showing up in the post/page editor
Aljullu
force-pushed
the
fix/9428-prevent-pages-toggle-to-appear-in-post-editor
branch
from
7c79ea0 to
7de614a
Compare
imanish003
approved these changes
May 12, 2023
There was a problem hiding this comment.
Hi @Aljullu, I have verified the changes and everything is working as expected. Good job! 🙌🏻🚀
I have a quick question: Should we also add Epic to this pull request?
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Hmmm, I'm not sure. I used to do that, but then I noticed that ZenHub was counting story points twice if the issue + PR were added to the epic. That's why when a PR has an issue associated to it, I only add the issue to the Epic. Not sure if that's the correct think to do, though. 🤔 |
Aljullu
deleted the
fix/9428-prevent-pages-toggle-to-appear-in-post-editor
branch
|
@Aljullu I see. Let me ask in Slack to find the answer to this question. 🤝 |
Aljullu
added
the
skip-changelog
4 tasks
Aljullu
added a commit
that referenced
this pull request
May 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9428.
The code of this PR is based on similar code found in Gutenberg:
https://github.com/WordPress/gutenberg/blob/37d98396f63dd7463287fd9d2124a179a1f68458/packages/block-library/src/post-comments-form/form.js#L63
Note: I added the
skip-changeloglabel as it looks like #9428 was only reproducible onnpm run start, but not onnpm run build, so it never impacted users.Testing
User Facing Testing
WooCommerce Visibility