This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update Mini-Cart block logic to use isSiteEditorPage util #9501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: refactor
woocommercebot
requested review from
a team and
kmanijak
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +131 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
kmanijak
reviewed
May 18, 2023
There was a problem hiding this comment.
I tested this and:
- ✅ There is no Mini-Cart in cart and checkout pages toggle in post/page editor
- ✅ There is Mini-Cart in cart and checkout pages toggle in site editor
- ❌ There is no Mini-Cart in cart and checkout pages toggle when added in Appearance -> Widget of classic theme
Let me know if I may be doing something wrong 🤔
|
Reading the code, the check works well. If you read it, the The testing instructions aren't correct, or it is necessary to add another check like "isWidgetArea". |
Ouch, I don't know what I did wrong when testing. 😅 Probably I didn't build properly. Sorry about the confusion. I updated the testing steps accordingly. While I think there is value in making that feature available in the Widgets screen, we haven't received any reports asking for it, and it's not sure if we are going to keep it in the future, so maybe better not to enable it in more places for now. Until #9442 that feature wasn't enabled in the Widgets screen either, so we would be keeping things as they were. @kmanijak I asked for a re-review, but I didn't do any code changes, I just updated the testing steps. |
kmanijak
approved these changes
May 18, 2023
There was a problem hiding this comment.
@kmanijak I asked for a re-review, but I didn't do any code changes, I just updated the testing steps.
✅ There is no Mini-Cart in cart and checkout pages toggle when added in Appearance -> Widget of classic theme
All's good then! Approving! 💪
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9468, @gigitux introduced a
isSiteEditorPage()util to detect when we are in the site editor.This PR reverts #9442 and updates the Mini-Cart block logic code to use that util, instead of its own solution.
Testing
User Facing Testing
WooCommerce Visibility