Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay pipeline using cli exec by downloading metadata #4103

Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 11, 2024

closes #1155

image
image


Sponsored by Kithara Software GmbH

@6543 6543 added server ui frontend related feature add new functionality cli labels Sep 11, 2024
@6543 6543 mentioned this pull request Sep 11, 2024
28 tasks
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Sep 11, 2024

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 48 lines in your changes missing coverage. Please review.

Project coverage is 26.60%. Comparing base (1a6c8df) to head (67bb314).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
cli/exec/exec.go 0.00% 15 Missing ⚠️
cli/exec/metadata.go 87.50% 8 Missing and 4 partials ⚠️
woodpecker-go/woodpecker/pipeline.go 0.00% 10 Missing ⚠️
server/api/pipeline.go 68.00% 6 Missing and 2 partials ⚠️
server/pipeline/items.go 0.00% 2 Missing ⚠️
server/router/api.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4103      +/-   ##
==========================================
+ Coverage   26.20%   26.60%   +0.40%     
==========================================
  Files         373      373              
  Lines       27035    27081      +46     
==========================================
+ Hits         7084     7205     +121     
+ Misses      19295    19213      -82     
- Partials      656      663       +7     
Flag Coverage Δ
26.60% <68.42%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@6543 6543 marked this pull request as ready for review September 12, 2024 09:54
@qwerty287
Copy link
Contributor

Can you post a screenshot?

@6543
Copy link
Member Author

6543 commented Sep 12, 2024

image
image

more debug things could be added here later ... like to halt an pipeline and let exermine the curent state (e.g. dont cleanup the workspace) etc ...

@6543
Copy link
Member Author

6543 commented Sep 12, 2024

@qwerty287
Copy link
Contributor

And what's inside this tab? How does it look there currently?

@6543
Copy link
Member Author

6543 commented Sep 12, 2024

second screenshot is with tab klicked .. it crrently only contains an dropdown and an button.

If you know a beter UI/UX please tell :) thats the best i did come up with

Copy link
Contributor

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secret values should not be returned, could be replaced with something like <redacted>

@6543
Copy link
Member Author

6543 commented Sep 13, 2024

Secret values should not be returned, could be replaced with something like <redacted>

there should not be any secrets in this metadata else we do have a problem

@6543

This comment was marked as outdated.

@6543 6543 requested a review from anbraten September 23, 2024 13:31
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/views/repo/pipeline/PipelineDebug.vue Outdated Show resolved Hide resolved
web/src/components/user/UserCLIAndAPITab.vue Outdated Show resolved Hide resolved
web/src/views/repo/pipeline/PipelineDebug.vue Outdated Show resolved Hide resolved
6543 and others added 3 commits September 24, 2024 22:05
@6543
Copy link
Member Author

6543 commented Sep 24, 2024

@anbraten applyed

cli/exec/flags.go Outdated Show resolved Hide resolved
@anbraten anbraten enabled auto-merge (squash) September 25, 2024 05:13
@anbraten anbraten merged commit fcc57df into woodpecker-ci:main Sep 25, 2024
7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 25, 2024
1 task
@6543 6543 deleted the feat/download-and-use-metadata-in-exec branch September 25, 2024 05:49
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli feature add new functionality highlight server ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to download pipline metadata via UI to replay with cli
5 participants