Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly init workflow metadata for cli exec #4211

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 9, 2024

fix regression of #4103

@6543 6543 added bug Something isn't working cli regression fix a bug that was not released yet labels Oct 9, 2024
@6543
Copy link
Member Author

6543 commented Oct 9, 2024

that silli bug got in likely in between seperating stuff to seperate pulls and resolving merge conflicts ...

@6543 6543 requested a review from a team October 9, 2024 09:52
@woodpecker-bot
Copy link
Collaborator

Deploying preview to https://woodpecker-ci-woodpecker-pr-4211.surge.sh

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.47%. Comparing base (ddd55ee) to head (23ef12b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/exec/exec.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4211   +/-   ##
=======================================
  Coverage   26.47%   26.47%           
=======================================
  Files         376      376           
  Lines       27465    27465           
=======================================
  Hits         7270     7270           
  Misses      19530    19530           
  Partials      665      665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anbraten anbraten changed the title cli exec: init workflow metadata Correctly init workflow metadata for cli exec Oct 9, 2024
@6543 6543 enabled auto-merge (squash) October 9, 2024 10:08
@6543 6543 merged commit 2e29d43 into woodpecker-ci:main Oct 9, 2024
7 checks passed
@6543 6543 deleted the cli/exec/fix-nil branch October 9, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli regression fix a bug that was not released yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants