Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project settings descriptions #4410

Merged
merged 20 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions web/src/assets/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"not_allowed": "You are not allowed to access this repository's settings",
"general": {
"general": "General",
"project": "Project settings",
"project": "Repository settings",
6543 marked this conversation as resolved.
Show resolved Hide resolved
"save": "Save settings",
"success": "Repository settings updated",
"pipeline_path": {
Expand All @@ -82,29 +82,29 @@
},
"allow_pr": {
"allow": "Allow Pull Requests",
"desc": "Pipelines can run on pull requests."
"desc": "Allow pipelines to run on pull requests."
},
"allow_deploy": {
"allow": "Allow deployments",
"desc": "Allow deployments from successful pipelines. Only use if you trust all users with push access."
"desc": "Permit 'deployment' runs for successful pipelines. All users with with push permissions can trigger these, so use with caution."
xoxys marked this conversation as resolved.
Show resolved Hide resolved
},
"netrc_only_trusted": {
"netrc_only_trusted": "Only inject netrc credentials into trusted clone plugins",
"desc": "If enabled, git netrc credentials are only available for trusted clone plugins set in `WOODPECKER_PLUGINS_TRUSTED_CLONE`. Otherwise, all clone plugins can use the netrc credentials. This option has no effect on non-clone steps."
"netrc_only_trusted": "Only inject git credentials into trusted clone plugins",
anbraten marked this conversation as resolved.
Show resolved Hide resolved
"desc": "When enabled, git credentials are accessible only to trusted clone plugins specified in WOODPECKER_PLUGINS_TRUSTED_CLONE. Otherwise, custom clone plugins can use git credentials. This setting has no affect on non-clone steps."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually only valid if we merge #4346

},
"trusted": {
"trusted": "Trusted",
"network": {
"network": "Network",
"desc": "Underlying pipeline containers get access to network privileges like changing DNS."
"desc": "Pipeline container get access to network privileges like changing DNS."
6543 marked this conversation as resolved.
Show resolved Hide resolved
},
"volumes": {
"volumes": "Volumes",
"desc": "Underlying pipeline containers get access to volume privileges."
"desc": "Pipeline container are allowed to mount volumes."
},
"security": {
"security": "Security",
"desc": "Underlying pipeline containers get access to security privileges."
"desc": "Pipeline container get access to security privileges."
}
},
"visibility": {
Expand All @@ -128,7 +128,7 @@
},
"cancel_prev": {
"cancel": "Cancel previous pipelines",
"desc": "Enable to cancel pending and running pipelines of the same event and context before starting the newly triggered one."
"desc": "Selected event triggers will cancel pending and running pipelines of the same event before starting the most recent one."
}
},
"crons": {
Expand Down Expand Up @@ -502,12 +502,12 @@
"access_denied": "You are not allowed to access this instance",
"invalid_state": "The OAuth state is invalid",
"require_approval": {
"require_approval_for": "Require approval for",
"none": "No approval required",
"none_desc": "This setting can be dangerous and should only be used on private forges where all users are trusted.",
"forks": "Pull request from forked repositories",
"desc": "Prevent malicious pipelines from exposing secrets or running harmful tasks by approving them before execution.",
"require_approval_for": "Approval requirements",
"none": "None",
"none_desc": "Every event triggers builds, including pull requests. This setting can be dangerous and is only recommended for private instances.",
pat-s marked this conversation as resolved.
Show resolved Hide resolved
"forks": "Pull request from forked repository",
xoxys marked this conversation as resolved.
Show resolved Hide resolved
"pull_requests": "All pull requests",
"all_events": "All events from forge",
"desc": "Prevent malicious pipelines from exposing secrets or running harmful tasks by approving them before execution."
"all_events": "Any event trigger"
}
}
4 changes: 2 additions & 2 deletions web/src/views/repo/settings/General.vue
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<template>
<Settings :title="$t('repo.settings.general.general')">
<Settings :title="$t('repo.settings.general.project')">
<form v-if="repoSettings" class="flex flex-col" @submit.prevent="saveRepoSettings">
<InputField
docs-url="docs/usage/project-settings#project-settings-1"
:label="$t('repo.settings.general.project')"
:label="$t('repo.settings.general.general')"
>
<Checkbox
v-model="repoSettings.allow_pr"
Expand Down