Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project settings descriptions #4410

Merged
merged 20 commits into from
Nov 22, 2024
Merged

Improve project settings descriptions #4410

merged 20 commits into from
Nov 22, 2024

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Nov 18, 2024

No description provided.

@pat-s pat-s added enhancement improve existing features ux user experience labels Nov 18, 2024
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/assets/locales/en.json Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
pat-s and others added 2 commits November 19, 2024 10:49
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
@pat-s pat-s requested review from anbraten and xoxys November 19, 2024 13:51
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/assets/locales/en.json Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
@pat-s pat-s requested a review from anbraten November 21, 2024 08:07
@pat-s
Copy link
Contributor Author

pat-s commented Nov 21, 2024

Can't infer the test failures. Can somebody help?

@6543
Copy link
Member

6543 commented Nov 21, 2024

For the docs errors ... it looks like the dns at hetzner side is bit flaky ... so i suggest to ignore it atm ... and adress it in a pull that adds retry logic to the docs plugin and also better error handling

@pat-s
Copy link
Contributor Author

pat-s commented Nov 21, 2024

The error only occurs in this PR so I think it is a valid one.

Copy link
Member

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the docs git credentials is written with uppercase letter while UI locale file is using git credentials, can we decide for one? 😇

@xoxys
Copy link
Member

xoxys commented Nov 21, 2024

The error only occurs in this PR so I think it is a valid one.

This is a nodejs regression see facebook/docusaurus#10684 and nodejs/node#55826. I have pinned the node image to 23.1 for now, as 23.3 is not available yet.

@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Nov 21, 2024

Deployment of preview was torn down

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.60%. Comparing base (d3e73d1) to head (2f3d63f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4410      +/-   ##
==========================================
- Coverage   27.62%   27.60%   -0.02%     
==========================================
  Files         381      381              
  Lines       27894    27894              
==========================================
- Hits         7705     7700       -5     
- Misses      19505    19510       +5     
  Partials      684      684              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

.woodpecker/docs.yaml Outdated Show resolved Hide resolved
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
@pat-s pat-s merged commit 196e2b6 into main Nov 22, 2024
8 of 9 checks passed
@pat-s pat-s deleted the feat/project-settings branch November 22, 2024 08:28
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 22, 2024
1 task
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being that late, but I was just translating and found these problems.

},
"volumes": {
"volumes": "Volumes",
"desc": "Underlying pipeline containers get access to volume privileges."
"desc": "Pipeline containers are allowed to mount volumes."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is actually more. It also gives access to tmpfs and devices.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I just saw that these are undocumented, so that's fine then

"netrc_only_trusted": "Only inject netrc credentials into trusted clone plugins",
"desc": "If enabled, git netrc credentials are only available for trusted clone plugins set in `WOODPECKER_PLUGINS_TRUSTED_CLONE`. Otherwise, all clone plugins can use the netrc credentials. This option has no effect on non-clone steps."
"netrc_only_trusted": "Only inject git credentials into trusted clone plugins",
"desc": "When enabled, git credentials are accessible only to trusted clone plugins specified in WOODPECKER_PLUGINS_TRUSTED_CLONE. Otherwise, custom clone plugins can use git credentials. This setting has no affect on non-clone steps."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually only valid if we merge #4346

@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features ux user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants