-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve project settings descriptions #4410
Conversation
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
Co-authored-by: Anbraten <anton@ju60.de>
Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>
Can't infer the test failures. Can somebody help? |
For the docs errors ... it looks like the dns at hetzner side is bit flaky ... so i suggest to ignore it atm ... and adress it in a pull that adds retry logic to the docs plugin and also better error handling |
The error only occurs in this PR so I think it is a valid one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the docs git credentials
is written with uppercase letter while UI locale file is using git credentials
, can we decide for one? 😇
This is a nodejs regression see facebook/docusaurus#10684 and nodejs/node#55826. I have pinned the node image to 23.1 for now, as 23.3 is not available yet. |
Deployment of preview was torn down |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4410 +/- ##
==========================================
- Coverage 27.62% 27.60% -0.02%
==========================================
Files 381 381
Lines 27894 27894
==========================================
- Hits 7705 7700 -5
- Misses 19505 19510 +5
Partials 684 684 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being that late, but I was just translating and found these problems.
}, | ||
"volumes": { | ||
"volumes": "Volumes", | ||
"desc": "Underlying pipeline containers get access to volume privileges." | ||
"desc": "Pipeline containers are allowed to mount volumes." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is actually more. It also gives access to tmpfs and devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I just saw that these are undocumented, so that's fine then
"netrc_only_trusted": "Only inject netrc credentials into trusted clone plugins", | ||
"desc": "If enabled, git netrc credentials are only available for trusted clone plugins set in `WOODPECKER_PLUGINS_TRUSTED_CLONE`. Otherwise, all clone plugins can use the netrc credentials. This option has no effect on non-clone steps." | ||
"netrc_only_trusted": "Only inject git credentials into trusted clone plugins", | ||
"desc": "When enabled, git credentials are accessible only to trusted clone plugins specified in WOODPECKER_PLUGINS_TRUSTED_CLONE. Otherwise, custom clone plugins can use git credentials. This setting has no affect on non-clone steps." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually only valid if we merge #4346
No description provided.