Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim space from agent token #4465

Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 26, 2024

so e.g. newlines don't mather if you load the secret from an file

so e.g. newlines dont mather if you load the secret from an file
@6543 6543 added agent enhancement improve existing features ux user experience labels Nov 26, 2024
@6543 6543 changed the title Trim space for grpc agent token Trim space for agent secret Nov 26, 2024
@xoxys xoxys changed the title Trim space for agent secret Trim space from agent token Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.98%. Comparing base (bf1750a) to head (a33e91c).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4465      +/-   ##
==========================================
+ Coverage   27.94%   27.98%   +0.03%     
==========================================
  Files         383      384       +1     
  Lines       28044    28048       +4     
==========================================
+ Hits         7837     7848      +11     
+ Misses      19519    19511       -8     
- Partials      688      689       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pat-s pat-s merged commit b23c724 into woodpecker-ci:main Nov 26, 2024
9 checks passed
@woodpecker-bot
Copy link
Collaborator

@6543
Copy link
Member Author

6543 commented Nov 27, 2024

skip-changelog as bigger followup is at #4468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent enhancement improve existing features skip-changelog ux user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants