Trim space to all config flags that allow to read value from file #4468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
files often have a newline at the end but we expect simple values, so we should trim space for these options.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4468 +/- ##
=======================================
Coverage 28.22% 28.22%
=======================================
Files 385 385
Lines 27847 27847
=======================================
Hits 7860 7860
Misses 19296 19296
Partials 691 691 ☔ View full report in Codecov by Sentry. |
xoxys
requested changes
Nov 27, 2024
6543
commented
Nov 28, 2024
xoxys
approved these changes
Nov 28, 2024
|
Tearing down https://woodpecker-ci-woodpecker-pr-4468.surge.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files often have a newline at the end but we expect simple values, so we should trim space for these options.
based on urfave/cli#2013 (comment)
followup to #4465