Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] [GB-Mobile] Activate Preformatted block #10764

Closed
wants to merge 331 commits into from
Closed

[Draft] [GB-Mobile] Activate Preformatted block #10764

wants to merge 331 commits into from

Conversation

daniloercoli
Copy link
Contributor

@daniloercoli daniloercoli commented Nov 8, 2019 •
edited
Loading

This is the WP-Android side PR of wordpress-mobile/gutenberg-mobile#1442
that adds Preformated block to the list of available blocks in GB-Mobile.

To test:
See testing steps in the GB-mobile PR.

Note: Make sure to target the release branch.

cc @marecar3

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

malinajirka and others added 30 commits November 5, 2019 14:01
@malinajirka
Fix lint issues
84bf338
@planarvoid
Update post in proxy
c4f4b90
@planarvoid
Fix tests
2cba1c1
@malinajirka
Add tests for UploadMediaUseCase
65204ad
@malinajirka
Add tests for UpdateMediaModelUseCase
2a12b85
@malinajirka
Add tests for RetryFailedMediaUploadUseCase
e35abaf
@malinajirka
Add tests for RetryFailedMediaUploadUseCase
3803b7f
added utility function for encrypting AppLog using libsodium
092a91d
* using UTF-8 encoding when converting String to bytes
28b5eca 
* using NO_WRAP flag when encoding to base64
now base64 decoding the public key before using
02f9e70 
made base64 encode/decode flags a bit easier to set
added a new line to the log line after we split the lines in the AppLog
735f6ff 
cleaned up some of the code
fixed some style issues
34fc367
fixed an issue with not using the correct byte array length when encr…
7fba3e4 
…ypting log lines

removed reference to an exception that is no longer used
cleaned up some comments
7334b74
fixed style issue
92d6557
@planarvoid
Fix blocked UI
2a1fa70
@malinajirka
Minor refactoring of tests in editor.media
c5dd318
@planarvoid
Merge branch 'develop' into feature/make_gcm_message_service_not_static
e74ca16
@malinajirka
Add tests for OptimizeMediaUseCase
b68c0ab
@planarvoid
Address PR comments
14197b9
@malinajirka
Add tests for GetMediaModelUseCase
65e6ac9
@malinajirka
Add tests for CopyMediaToAppSotrageUseCase
d3b43bf
@planarvoid
Update media in transaction
2062fea
@malinajirka
Add tests for AppendMediaToEditorUseCase
f197d2b
@malinajirka
Add tests for AddLocalMediaToPostUseCaseTest
1f686a6
extracted some tags into class constants for consistency
834eb16
@planarvoid
Use immutable post model
d2f3505
@planarvoid
Revert empty return value from MediaUpoadReadyProcessor
073b3fe
@planarvoid
Cleanup
3af2424
@planarvoid
Fix UI test
824dc32
planarvoid and others added 26 commits November 25, 2019 15:16
@planarvoid
Merge pull request #10837 from chipsnyder/issue/9183-fetch-then-group…
722dcd2 
…-posts-ui

Search all posts and group results into sections
@develric
Merge pull request #10848 from wordpress-mobile/fix/do_not_reload_wid…
5e17c66 
…gets_on_no_network

Stop hiding data when there is no connection
@planarvoid
Merge branch 'develop' into feature/make_number_suffixes_translatable
cc052b0
@planarvoid
Handle properly nullable numbers in StatsUtils
9a6d791
@planarvoid
Add tests for StatsUtils method to cover all number formats
0c12f68
@planarvoid
Add tests for new methods in stats utils
f9ffab0
@planarvoid
Add comment to downloadExternalMedia method
7339e41
@planarvoid
Move toast to the correct else branch
60bcddc
@planarvoid
Fix tests
31b02ce
@planarvoid
Do not trigger fragment change when the activity was already closed
c09e6ec
@planarvoid
Add comment to the change
7a4a614
@planarvoid
Replace the link to the PR with the issue
fb1e97f
@planarvoid
Do not refresh site details when view not initialized
2f61054
@jd-alexander
Modified colour value to get rid of contrast warning.
4837104
@jd-alexander
Updated the semantics of the toolbar content description functionality.
7f26741
@jd-alexander
SearchView hint color functionality made static.
fe68ca6
@malinajirka
Merge pull request #10826 from wordpress-mobile/fix/null_site_model
db16763 
Fix null site model in PostListActivity
@malinajirka
Merge pull request #10824 from wordpress-mobile/fix/save_remote_uris_…
19ac4e6 
…in_share_receiver

Download external media on Share intent received
@malinajirka
Merge pull request #10818 from wordpress-mobile/feature/make_number_s…
648ccd8 
…uffixes_translatable

Make number suffixes translatable through an injected class
@malinajirka
Merge pull request #10853 from wordpress-mobile/fix/crash_in_wp_main_…
244faa2 
…navigation_view

Do not trigger fragment change when the activity was already closed
@planarvoid
Fix crash when reading from ReaderPost JSON
6c46635
@develric
Merge pull request #10855 from wordpress-mobile/fix/do_not_refresh_si…
de3091d 
…te_details_when_view_not_initialized

Do not refresh site details when view not initialized
@develric
Merge pull request #10861 from wordpress-mobile/fix/crash_when_readin…
a921a9c 
…g_from_reader_post_json

Fix crash when reading from ReaderPost JSON
@shiki
Merge pull request #10799 from wordpress-mobile/issue/10735-accessibi…
429f5a1 
…lity-notifications

Accessibility : Notification Improvements
@marecar3
Merge branch 'develop' into gutenberg/1442-Activate-Preformatted-block-
4a817e9
@marecar3
Update aztecVersion
ab7d001 
Update gb-mobile hash
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps!
WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history!

  1. cd WordPress-Android
  2. git checkout gutenberg/1442-Activate-Preformatted-block-
  3. git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/WordPress-Android/10764
  4. Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/WordPress-Android/10764 and open a new PR.

Generated by 🚫 dangerJS

@marecar3
Copy link
Contributor

Closing in favor #10868

@marecar3 marecar3 closed this Nov 28, 2019
@marecar3 marecar3 deleted the gutenberg/1442-Activate-Preformatted-block- branch November 28, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
13.8
Development

Successfully merging this pull request may close these issues.