Gutenberg/activate preformat block #10868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update aztec version Call parser to HTML with extra parameter
Update aztec version
This was referenced Nov 28, 2019
|
You can test the changes on this Pull Request by downloading the APK here. |
1 task
marecar3
changed the title
marecar3
changed the title
hypest
reviewed
Dec 5, 2019
libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/AztecEditorFragment.java
Outdated
Show resolved
Hide resolved
|
Hey @hypest, I think that I have addressed all issues so this one is ready for another iteration of review. |
|
I've LGTM'd the PR but, let's update the Aztec hash to a tag before we merge. |
1 task
…o, otherwise app is crashing.
…date also, otherwise app is crashing." This reverts commit 0936b22.
# Conflicts: # libs/editor/WordPressEditor/build.gradle
|
It seems that the failing Firebase tests are not related to the work on this PR and happening on other commits merged to develop already so, we'll not fix them as part of this PR and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#1264
GB mobile PR: wordpress-mobile/gutenberg-mobile#1615
To test:
Follow test instructions on gb-mobile PR: wordpress-mobile/gutenberg-mobile#1615
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.