Automate updating gutenberg translations (void) #10807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for image preview requests from gb-editor
…ute image preview requests from GB editor to MediaPreviewActivity.
…oading and after failed upload.
…creen-preview Gutenberg image fullscreen preview
…-progressive-rollout Gutenberg progressive rollout
This reverts commit cfeaea6.
…utenberg/fix-i18n
Generated by 🚫 dangerJS |
Tug
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#939
Gutenberg PR: wordpress-mobile/gutenberg-mobile#1520
This PR automates adding gutenberg mobile strings to the main
strings.xmlfiles in order to have those translated by glotpress. It also adds support for plurals inGutenbergEditorFragment(need to check that glotpress can parse<plurals>tags).Testing Instructions
develop)python tools/merge_strings_xml.pyWordPress/src/main/res/values/strings.xmland make sure it contains all the strings from gutenberg-mobile/bundle/androidPR submission checklist:
Update the release process when the PR lands.
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.