Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix our i18n process #939

Closed
Tug opened this issue Apr 29, 2019 · 3 comments · Fixed by #1520, wordpress-mobile/WordPress-iOS#12811 or wordpress-mobile/WordPress-Android#10807
Closed
Assignees
Labels
App Integration [Type] Bug Something isn't working

Comments

@Tug
Copy link
Contributor

Tug commented Apr 29, 2019

Internationalization is broken since Gutenberg moved away from babel-plugin-makepot.

Indeed, build files for each packages in gutenberg is now used as input for glotpress to generate pot files. This means our assumption that mobile native strings in the gutenberg repository will be picked up automatically was wrong.

We need to fix this and either:

  1. have gutenberg include our strings
  2. include those in our gutenberg-mobile.pot.

Solution 2. is probably more realistic as it will induce less friction with the WordPress core and Gutenberg projects but will bring us one step back in terms of automating translations for gutenberg-mobile.

See related discussions:
https://make.wordpress.org/core/2018/11/09/new-javascript-i18n-support-in-wordpress/
https://make.wordpress.org/core/2018/05/01/javascript-internationalization-the-missing-pieces/
https://wordpress.slack.com/archives/C04KRK0KA/p1525791742000720
https://meta.trac.wordpress.org/ticket/3876

@Tug Tug added [Type] Bug Something isn't working App Integration labels Apr 29, 2019
@Tug Tug self-assigned this Apr 29, 2019
@swissspidy
Copy link

Let me know if I can help with the i18n part in Gutenberg, WordPress core, or WordPress.org.

@hypest
Copy link
Contributor

hypest commented Aug 8, 2019

Not sure if you're actively working on this one @Tug , if so, better to move the ticket to the "In Progress" column in the project board, otherwise let's un-assign the ticket. Thanks!

@Tug Tug removed their assignment Aug 8, 2019
@Tug
Copy link
Contributor Author

Tug commented Aug 8, 2019

👍 Unassigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment