-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Multiple selection of media in gutenberg #12404
Feat: Multiple selection of media in gutenberg #12404
Conversation
WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/GutenbergMediaInserterHelper.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/GutenbergMediaInserterHelper.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/GutenbergMediaInserterHelper.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/GutenbergMediaInserterHelper.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift
Outdated
Show resolved
Hide resolved
I see that this is a draft but the gutenberg-mobile PR looks ready to review. Is this still work in progress? If yes, you might want to mark gutenberg-mobile PR as |
Hi all, this PR is ready. Could you please make a CR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good, thanks! 🎉
Interestingly CI fails with error:
@jtreanor maybe you know this, this PR uses another fork. Is this expected? |
@pinarol Thanks for the heads up. It looks like the CI failure is a configuration issue on our part. A recent change doesn't seem to be working correctly. I will look into a solution for it and update here. |
thank you @jtreanor 👍 |
Could you update your branch from latest develop? @dratwas After that CI should be working |
In this PR I added the possibility to set multiple media when inserting to the block.
Related
gutenberg-mobile
PR wordpress-mobile/gutenberg-mobile#1331To test:
At this moment we don't support
gallery block
so this change can not be tested without changes ingutenberg-mobile
JS bundle. In the future, we will use this functionality to multiple selections of media for the gallery.