-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: support of multiple selection in media upload #1331
Conversation
986bf70
to
0dca9b4
Compare
react-native-gutenberg-bridge/ios/GutenbergBridgeDelegate.swift
Outdated
Show resolved
Hide resolved
react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.swift
Outdated
Show resolved
Hide resolved
react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.swift
Outdated
Show resolved
Hide resolved
This is looking pretty good overall, I just wanted to point out some things early on. So what are some pending work here? |
Prop And Android implementation |
thanks @dratwas ! did you have chance to try multiple uploads also? |
really appreciate that! |
AFAIK this is a responsibility of the |
That's actually enough for this particular task thanks! Sorry If I confused you, the rest will be handled in |
Could you be able to update the branch from |
Could you also add the associated issue to PR description? |
Could you be able to update the branch resolve merge conflicts one more time? Sorry for being late for reviewing, I'll start after this. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS changes look good to me 🎉
I tested this on Android, and it is working nicely. 🎉 |
In this PR I added support for multiple selections of media in MediaUpload component. It is a breaking change and apps will crash without changes from listed PRs.
Associated issue - #1298
Related gutenberg PR - WordPress/gutenberg#17397
Related Wordpres-iOS PR - wordpress-mobile/WordPress-iOS#12404
Related Wordpress-Android PR - wordpress-mobile/WordPress-Android#10556
To test:
NOTE: Multiple selections of media from the device on iOS doesn't work since this functionality is implemented by the client app. Our example app from
ios
directory doesn't support multiple selections from the device because it uses build-inUIImagePickerController
. In order to make it works in our example app, I would need to add an external library that supports multiple selections.