Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate updating gutenberg translations #12811

Merged
merged 9 commits into from
Nov 12, 2019
Merged

Automate updating gutenberg translations #12811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
644e6a6
Target a dynamic localizable file instead
Tug Oct 30, 2019
f8ef73b
Target gutenberg PR which has the dynamic file
Tug Oct 31, 2019
89f8241
Update englisn localization file
Tug Oct 31, 2019
036a9fa
Update gb dependency
Tug Nov 7, 2019
c36f3b6
Merge remote-tracking branch 'origin/develop' into gutenberg/fix-i18n
Tug Nov 7, 2019
6cac2d2
Update Podfile.lock
Tug Nov 7, 2019
dae8b92
Update english Localizable.strings
Tug Nov 7, 2019
cfaea4b
Merge remote-tracking branch 'origin/develop' into gutenberg/fix-i18n
Tug Nov 8, 2019
d66fb82
Revert changes to en.lproj/Localizable.strings
Tug Nov 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Scripts/localize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def localize(path, language, include_pods_and_frameworks):

# TODO: This is super ugly, we have to come up with a better way of doing it
if include_pods_and_frameworks:
find_cmd = 'find . ../Pods/WordPress* ../Pods/WPMediaPicker ../WordPressComStatsiOS/WordPressComStatsiOS ../WordPressShared/WordPressShared -name "*.m" -o -name "*.swift" | grep -v Vendor'
find_cmd = 'find . ../Pods/WordPress* ../Pods/WPMediaPicker ../WordPressComStatsiOS/WordPressComStatsiOS ../WordPressShared/WordPressShared ../Pods/Gutenberg -name "*.m" -o -name "*.swift" | grep -v Vendor'
else:
find_cmd = 'find . -name "*.m" -o -name "*.swift" | grep -v Vendor'
filelist = os.popen(find_cmd).read().strip().split('\n')
Expand Down
27 changes: 0 additions & 27 deletions WordPress/Classes/Utility/GutenbergTranslator.swift
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions WordPress/WordPress.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1792,7 +1792,6 @@
E1D86E691B2B414300DD2192 /* WordPress-32-33.xcmappingmodel in Sources */ = {isa = PBXBuildFile; fileRef = E1D86E681B2B414300DD2192 /* WordPress-32-33.xcmappingmodel */; };
E1D91456134A853D0089019C /* Localizable.strings in Resources */ = {isa = PBXBuildFile; fileRef = E1D91454134A853D0089019C /* Localizable.strings */; };
E1D95EB817A28F5E00A3E9F3 /* WPActivityDefaults.m in Sources */ = {isa = PBXBuildFile; fileRef = E1D95EB717A28F5E00A3E9F3 /* WPActivityDefaults.m */; };
E1DAC8FA221F1C8D00833FFC /* GutenbergTranslator.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1DAC8F8221F1C0500833FFC /* GutenbergTranslator.swift */; };
E1DB326C1D9ACD4A00C8FEBC /* ReaderTeamTopic.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1DB326B1D9ACD4A00C8FEBC /* ReaderTeamTopic.swift */; };
E1DD4CCB1CAE41B800C3863E /* PagedViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1DD4CCA1CAE41B800C3863E /* PagedViewController.swift */; };
E1DD4CCD1CAE41C800C3863E /* PagedViewController.xib in Resources */ = {isa = PBXBuildFile; fileRef = E1DD4CCC1CAE41C800C3863E /* PagedViewController.xib */; };
Expand Down Expand Up @@ -4162,7 +4161,6 @@
E1D91457134A854A0089019C /* es */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = es; path = es.lproj/Localizable.strings; sourceTree = "<group>"; };
E1D95EB617A28F5E00A3E9F3 /* WPActivityDefaults.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WPActivityDefaults.h; sourceTree = "<group>"; };
E1D95EB717A28F5E00A3E9F3 /* WPActivityDefaults.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = WPActivityDefaults.m; sourceTree = "<group>"; };
E1DAC8F8221F1C0500833FFC /* GutenbergTranslator.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GutenbergTranslator.swift; sourceTree = "<group>"; };
E1DB326B1D9ACD4A00C8FEBC /* ReaderTeamTopic.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ReaderTeamTopic.swift; sourceTree = "<group>"; };
E1DB326D1D9AE60900C8FEBC /* WordPress 52.xcdatamodel */ = {isa = PBXFileReference; lastKnownFileType = wrapper.xcdatamodel; path = "WordPress 52.xcdatamodel"; sourceTree = "<group>"; };
E1DD4CCA1CAE41B800C3863E /* PagedViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; lineEnding = 0; path = PagedViewController.swift; sourceTree = "<group>"; xcLanguageSpecificationIdentifier = xcode.lang.swift; };
Expand Down Expand Up @@ -6830,7 +6828,6 @@
594DB2941AB891A200E2E456 /* WPUserAgent.m */,
FF28B3EF1AEB251200E11AAE /* InfoPListTranslator.h */,
FF28B3F01AEB251200E11AAE /* InfoPListTranslator.m */,
E1DAC8F8221F1C0500833FFC /* GutenbergTranslator.swift */,
85B125431B02937E008A3D95 /* UIAlertControllerProxy.h */,
85B125441B02937E008A3D95 /* UIAlertControllerProxy.m */,
7E846FF020FD0A0500881F5A /* ContentCoordinator.swift */,
Expand Down Expand Up @@ -11421,7 +11418,6 @@
E17FEADA221494B2006E1D2D /* Blog+Analytics.swift in Sources */,
E69551F61B8B6AE200CB8E4F /* ReaderStreamViewController+Helper.swift in Sources */,
E61084BE1B9B47BA008050C5 /* ReaderAbstractTopic.swift in Sources */,
E1DAC8FA221F1C8D00833FFC /* GutenbergTranslator.swift in Sources */,
2F08ECFC2283A4FB000F8E11 /* PostService+UnattachedMedia.swift in Sources */,
E61084BF1B9B47BA008050C5 /* ReaderDefaultTopic.swift in Sources */,
D816C1F220E0894D00C4D82F /* ReplyToComment.swift in Sources */,
Expand Down