Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate updating gutenberg translations #12811

Merged
merged 9 commits into from
Nov 12, 2019
Merged

Automate updating gutenberg translations #12811

merged 9 commits into from
Nov 12, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Oct 30, 2019 •
edited
Loading

Fixes wordpress-mobile/gutenberg-mobile#939

Gutenberg PR: wordpress-mobile/gutenberg-mobile#1520

This PR automates adding gutenberg mobile strings to the main Localizable.strings files in order to have those translated by glotpress.

@Tug Tug self-assigned this Oct 30, 2019
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 30, 2019 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@Tug Tug added [Status] Not Ready for Review Gutenberg Editing and display of Gutenberg blocks. labels Oct 30, 2019
@Tug Tug added this to the 13.6 milestone Oct 30, 2019
@loremattei
Copy link
Contributor

Hey there! I moved this to 13.7 since 13.6 has been cut. If you want this to make it to 13.6, please feel free to move it back, target the release branch and ping me to coordinate a new beta release.

@loremattei loremattei modified the milestones: 13.6 ❄️, 13.7 Nov 4, 2019
@Tug Tug mentioned this pull request Nov 7, 2019
Merged
@Tug
Copy link
Contributor Author

Tug commented Nov 8, 2019

We cannot merge this without creating a new gutenberg release so I suggest we just merge the script changes here and remove the old translation file that we don't need anymore.

@loremattei loremattei added Gutenberg Editing and display of Gutenberg blocks. and removed Gutenberg Editing and display of Gutenberg blocks. labels Nov 11, 2019
loremattei
loremattei approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@loremattei loremattei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Neat solution that relies on the existing tools.
I tested it using the current mobile-gutenberg develop and I verified that the strings in GutenbergNativeTranslations.swift have been added to the main localizable.strings.

:shipit:

@Tug
Copy link
Contributor Author

Tug commented Nov 12, 2019

@loremattei Thanks for the review!
I'm merging this to develop and will update #12917 afterwards

@Tug Tug merged commit 9f5e5ec into develop Nov 12, 2019
@Tug Tug deleted the gutenberg/fix-i18n branch November 12, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loremattei loremattei loremattei approved these changes

@mchowning mchowning Awaiting requested review from mchowning

@hypest hypest Awaiting requested review from hypest

Assignees

@Tug Tug

Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
13.7
Development

Successfully merging this pull request may close these issues.

Fix our i18n process
2 participants
@Tug @loremattei