-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate updating gutenberg translations #12811
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
Hey there! I moved this to 13.7 since 13.6 has been cut. If you want this to make it to 13.6, please feel free to move it back, target the release branch and ping me to coordinate a new beta release. |
840fa77
to
c36f3b6
Compare
We cannot merge this without creating a new gutenberg release so I suggest we just merge the script changes here and remove the old translation file that we don't need anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Neat solution that relies on the existing tools.
I tested it using the current mobile-gutenberg
develop
and I verified that the strings in GutenbergNativeTranslations.swift
have been added to the main localizable.strings
.
@loremattei Thanks for the review! |
Fixes wordpress-mobile/gutenberg-mobile#939
Gutenberg PR: wordpress-mobile/gutenberg-mobile#1520
This PR automates adding gutenberg mobile strings to the main
Localizable.strings
files in order to have those translated by glotpress.