-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dismiss suggestions on space keystroke #16770
Conversation
Users expect the suggestions UI to be dismissed when typing a space immediately after a trigger character (e.g. `@` for mentions, `+` for cross-posts).
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Testing 7b74c84 on iPhone 11:
|
@guarani, I just wanted to share that the Android side was approved and I (perhaps too hastily!) merged it today. Let me know if that seems okay to you or if you think it'd be best to revert the merge in order to make sure these are both aligned. |
Sorry @SiobhyB, I missed this ping. I'd say it's OK 👍 It shouldn't be a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This tested for me as advertised.
Addresses WordPress/gutenberg#24425 (for iOS)
Note: This PR replaces #16601 which was reverted after it was found that the PR overlooked updating analytics events.
This PR allows users to easily dismiss the suggestion UI by typing a space character after triggering the UI. This means it will now be easier to add a
@
character to a post without triggering the mentions suggestions UI, or add a+
character without triggering the cross-post suggestions UI.I added this change to suggestions in the block editor, but didn't apply it to other parts of the app (e.g. comments, notification replies, etc) because that felt too far out-of-scope here. It would also make the testing steps much longer.
To test:
Regression Notes
This change could conceivably break suggestions (both mentions and cross-posting).
The above manual tests.
This change affects the UI so a UI test would be best, but we only add UI tests to core flows.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.