Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate gutenberg-mobile release 1.59.2 #17040

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Integrate gutenberg-mobile release 1.59.2 #17040

merged 3 commits into from
Aug 17, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Aug 17, 2021 •
edited
Loading

Description

This PR incorporates the 1.59.2 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3844

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the Gutenberg Editing and display of Gutenberg blocks. label Aug 17, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 17, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 17, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 55103. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@fluiddot fluiddot added this to the 18.0 ❄️ milestone Aug 17, 2021
@fluiddot fluiddot mentioned this pull request Aug 17, 2021
Merged
5 tasks
@fluiddot fluiddot marked this pull request as ready for review August 17, 2021 11:45
@fluiddot fluiddot requested a review from dcalhoun August 17, 2021 11:45
dcalhoun
dcalhoun approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one comment merely as a reminder.

My understanding is the bug has been present for awhile. Because of that, we may should mention in the fix in the release notes. I believe it is too late for the note to be published to the App Store, but it might still be beneficial to include the note for posterity. WDYT?

Podfile Outdated Show resolved Hide resolved
@guarani guarani merged commit 0e6cc5d into release/18.0 Aug 17, 2021
@guarani guarani deleted the gutenberg/integrate_release_1.59.2 branch August 17, 2021 18:24
@mokagio mokagio mentioned this pull request Aug 18, 2021
Merged
@mokagio
Copy link
Contributor

mokagio commented Aug 18, 2021

@fluiddot this has been bundled as part of 18.0 beta 2 (18.0.0.2).

Thanks for your work 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fluiddot @mokagio @dcalhoun @guarani