Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Allow audio upload to premium users after Jetpack features removal #20291

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 9, 2023

This PR fixes a bug where premium users can't upload Audio files after the Jetpack features are removed. The issue was introduced in #19691.

NOTE: The issue addressed in this PR is only affecting the WordPress app as the removal of Jetpack features is only applied in that app.

To test

Preparation:

  1. Open the WordPress app.
  2. Go to "Debug" screen via "Me -> App Settings" screen.
  3. Enable "Jetpack Features Removal Phase Four" (when Jetpack features are removed)

Simple site - Paid plan

  1. Go to a Simple site with a paid plan.
  2. Open/create a post.
  3. Add an Audio block.
  4. In the "Choose audio" picker, observe that it displays the following options:
  • WordPress Media Library
  • Insert from URL
  • Other Apps

Simple site - Free site

  1. Go to a Simple site with the free plan.
  2. Open/create a post.
  3. Add an Audio block.
  4. In the "Choose audio" picker, observe that it only displays the option "Insert from URL".

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Type] Bug Gutenberg Editing and display of Gutenberg blocks. labels Mar 9, 2023
@fluiddot fluiddot added this to the 21.9 ❄️ milestone Mar 9, 2023
@fluiddot fluiddot self-assigned this Mar 9, 2023
@fluiddot fluiddot changed the base branch from trunk to release/21.9 March 9, 2023 14:28
@fluiddot fluiddot force-pushed the gutenberg/fix/enable-audio-block-upload branch from ccb9751 to bc82b26 Compare March 9, 2023 14:30
@fluiddot fluiddot marked this pull request as ready for review March 9, 2023 14:31
@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20291-bc82b26 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20291-bc82b26 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@fluiddot fluiddot requested review from derekblank and geriux March 9, 2023 15:27
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested this using the WordPress app following the test cases from the PR description. 🚀

@fluiddot fluiddot merged commit 8bbc0d5 into release/21.9 Mar 10, 2023
@fluiddot fluiddot deleted the gutenberg/fix/enable-audio-block-upload branch March 10, 2023 16:13
@mokagio mokagio mentioned this pull request Mar 15, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants