[Gutenberg] Disable editor Jetpack-powered features based on Jetpack Features Removal phases #19691

fluiddot · 2022-11-30T18:33:29Z

Gutenberg Mobile PR: Only register core blocks when onlyCoreBlocks capability is enabled gutenberg-mobile#5293

To test

The following features in the editor will be disabled when reaching the phase of disabling Jetpack-powered features:

Disable Jetpack blocks
- Remove Jetpack blocks from the block picker
- Display Jetpack blocks as unsupported
Disable @-mentions and X-posts features
Remove Editor’s help support
Remove Reusable blocks
Disable Unsupported Block Editor (UBE)

1 - Editor Jetpack-powered features ENABLED in WordPress app

Preparation

Navigate to App Settings in the WordPress app and open Debug settings.
Turn Jetpack Features Removal Phase Four and Jetpack Features Removal Phase For New Users flags off.

Check Jetpack blocks

Create a post.
Tap on ➕ Add Blocks button.
Scroll down the block list.
Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post.
Add all Jetpack blocks (Contact Info, Story, Layout Grid blocks).
Observe that all Jetpack blocks are displayed and can be edited.
Save the post with some Jetpack blocks (this post will be used in other test cases).

Check @-mentions and X-posts features

Add a Paragraph block.
Type the + character and observe that the x-post sheet is displayed.
NOTE: x-post feature only works in sites with the O2 plugin enabled like P2-based sites. In order to test this, please use a P2-based site.
Type the @ character and observe that the @-mentions sheet is displayed.
Observe that in the toolbar the @ format button is displayed.

Check the help's support section

Open a post.
Tap on the three dots button to open the contextual menu.
Observe that there's the option Help & Support that references Support, tap on it.
Observe that the section Get support is present.

Check Reusable blocks

Create a reusable block in the web version of the editor (instructions here).
Create a post in the app.
Tap on ➕ Add Blocks button.
Observe that in the bottom sheet the "Reusable" tab is shown.
Tap on the "Reusable" tab and insert a Reusable block.
Observe that the block is displayed.
Save the post with at least one Reusable block (this post will be used in other test cases).

Check Unsupported Block Editor (UBE)

Create a post in the web version of the editor.
Add a block that is not supported in the native version like the Table block.
Save the post (this post will be used in other test cases).
Open the same post in the app.
Observe that the block is displayed as unsupported.
Tap on the block and try to edit it with UBE.
Observe that it can be edited with UBE.

2 - Editor Jetpack-powered features DISABLED in WordPress app

Preparation

Navigate to App Settings in the WordPress app and open Debug settings.
Turn Jetpack Features Removal Phase Four flag on.

NOTE: It's recommended that the following test cases are also checked by turning the Jetpack Features Removal Phase For New Users flag on and Jetpack Features Removal Phase Four flag off in Debug settings.

Check Jetpack blocks

Open the previous post saved with Jetpack blocks.
Observe that the Jetpack blocks are displayed as unsupported.
Tap on a Jetpack block and observe that a bottom sheet is displayed indicating that the block is not supported.
Tap on ➕ Add Blocks button.
Scroll down the block list.
Observe that the Jetpack blocks are NOT present.

Check @-mentions and X-posts features

Add a Paragraph block.
Type the + character and observe that the x-post sheet is NOT displayed.
NOTE: x-post feature only works in sites with the O2 plugin enabled like P2-based sites. In order to test this, please use a P2-based site.
Type the @ character and observe that the @-mentions sheet is NOT displayed.
Observe that in the toolbar the @ format button is NOT displayed.

Check the help's support section

Open a post.
Tap on the three dots button to open the contextual menu.
Observe that there's the option Help but doesn't reference Support, tap on it.
Observe that the section Get support is NOT present.

Check Reusable blocks

Open the previous post saved with Reusable blocks.
Observe that the Reusable block is displayed as unsupported.
Tap on the block and observe that a bottom sheet is displayed indicating that the block is not supported.
Tap on ➕ Add Blocks button.
Observe that in the bottom sheet the "Reusable" tab is NOT shown.

Check Unsupported Block Editor (UBE)

Open the previous post saved with unsupported blocks.
Observe that the block is displayed as unsupported.
Tap on the block and observe that it can't be edited with UBE.

3- Editor Jetpack-powered features ENABLED in Jetpack app

Navigate to App Settings in the Jetpack app and open Debug settings.
Turn Jetpack Features Removal Phase Four flag on. This flag should be omitted by the Jetpack app.
Repeat the same test cases described in "1 - Editor Jetpack-powered features ENABLED in WordPress app":
- Check Jetpack blocks
- Check @-mentions and X-posts features
- Check the help's support section
- Check Reusable blocks
- Check Unsupported Block Editor (UBE)

Regression Notes

Potential unintended areas of impact
Only the editor should be affected.
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

wpmobilebot · 2022-12-07T19:45:34Z

You can test the changes in WordPress from this Pull Request by:

Clicking here or scanning the QR code below to access App Center
Then installing the build number pr19691-2788fa5 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

wpmobilebot · 2022-12-07T19:48:23Z

You can test the changes in Jetpack from this Pull Request by:

Clicking here or scanning the QR code below to access App Center
Then installing the build number pr19691-2788fa5 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

derekblank · 2022-12-13T08:09:03Z

Nice work @fluiddot. I've added my testing experiences -- they are all green, with the exception of the "Get Support" section appearing in the WordPress app when Jetpack-powered features are disabled. I'm curious if this matches your testing experiences.

1 - Editor Jetpack-powered features ENABLED in WordPress app:

Create a post. 🟢
Tap on ➕ Add Blocks button. 🟢
Scroll down the block list. 🟢
Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post. 🟢
Add some Jetpack blocks. 🟢
Add a Paragraph block. 🟢
Type the + character and observe that the x-post sheet is displayed. 🟢
Type the @ character and observe that the @-mentions sheet is displayed. 🟢
Observe that in the toolbar the @ format button is displayed. 🟢
Tap on the three dots button to open the contextual menu. 🟢
Observe that there's the option Help & Support that references Support, tap on it. 🟢
Observe that the section Get support is present. 🟢
Save the post with some Jetpack blocks and close the editor. 🟢

2 - Editor Jetpack-powered features DISABLED in WordPress app:

Navigate to App Settings and open Debug settings. 🟢
Turn Jetpack Features Removal Phase Four flag on. 🟢
Open the previous post saved with Jetpack blocks. 🟢
Observe that the Jetpack blocks are displayed as unsupported. 🟢
Tap on ➕ Add Blocks button. 🟢
Scroll down the block list. 🟢
Observe that the Jetpack blocks are NOT present. 🟢
Add a Paragraph block. 🟢
Type the + character and observe that the x-post sheet is NOT displayed. 🟢
Type the @ character and observe that the @-mentions sheet is NOT displayed. 🟢
Observe that in the toolbar the @ format button is NOT displayed. 🟢
Tap on the three dots button to open the contextual menu. 🟢
Observe that there's the option Help but doesn't reference Support, tap on it. 🟢
Observe that the section Get support is NOT present. 🔴

3- Editor Jetpack-powered features ENABLED in Jetpack app:

Navigate to App Settings and open Debug settings. 🟢
Turn Jetpack Features Removal Phase Four flag on. This flag should be omitted by the Jetpack app. 🟢
Create a post. 🟢
Tap on ➕ Add Blocks button. 🟢
Scroll down the block list. 🟢
Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post. ⚪ (I observe separate Jetpack blocks in a section list marked "Reusable", is this correct?)
Add a Paragraph block. 🟢
Type the + character and observe that the x-post sheet is displayed. 🟢
Type the @ character and observe that the @-mentions sheet is displayed. 🟢
Observe that in the toolbar the @ format button is displayed. 🟢
Tap on the three dots button to open the contextual menu.
Observe that there's the option Help & Support that references Support, tap on it. 🟢
Observe that the section Get support is present. 🟢

fluiddot · 2022-12-13T12:27:23Z

Thank you @derekblank for testing the changes 🙇 ! I went through the testing instructions again to check the steps that failed for you:

2 - Editor Jetpack-powered features DISABLED in WordPress app:

Observe that the section Get support is NOT present. 🔴

Good catch! It also failed when I tested the installable builds, however, succeeds when testing locally. This made me realize that I completely forgot to update the bundle in the Gutenberg Mobile PR 🤦, which basically means that the Gutenberg changes aren't included in the build. I'll generate a new RN bundle and create new installable builds.

2 - Editor Jetpack-powered features DISABLED in WordPress app:

Observe that the Jetpack blocks are displayed as unsupported. 🟢

It's interesting that this step succeeded in your case. Following the above comment, due to the fact that the RN bundle wasn't updated, the Jetpack blocks shouldn't have been displayed as unsupported since this was a new change 🤔.

fluiddot · 2022-12-13T13:25:45Z

I'll generate a new RN bundle and create new installable builds.

Bundle updated in e461d84. @derekblank let me know if could perform another review once the installable builds are generated, thanks!

hassaanelgarem · 2022-12-14T01:09:34Z

WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift

@@ -1191,6 +1191,30 @@ extension GutenbergViewController: GutenbergBridgeDataSource {
    func gutenbergCapabilities() -> [Capabilities: Bool] {
        let isFreeWPCom = post.blog.isHostedAtWPcom && !post.blog.hasPaidPlan
        let isWPComSite = post.blog.isHostedAtWPcom || post.blog.isAtomic()
+
+        // Disable Jetpack-powered editor features in WordPress app based on Features Removal coordination
+        if JetpackFeaturesRemovalCoordinator.generalPhase() == .four {


There are two phases where Jetpack features should be removed:

four

newUsers

I suggest adding a helper to identify whether features should be removed or not. Something along the lines of shouldRemoveJetpackFeatures. This helper should return true if the general phase is four or newUsers. What do you think?

Ah, true, thanks @hassaanelgarem for the call-up about the two phases 🙇 .

I suggest adding a helper to identify whether features should be removed or not. Something along the lines of shouldRemoveJetpackFeatures. This helper should return true if the general phase is four or newUsers. What do you think?

Good idea, I'll work on adding a function to determine when the Jetpack features should be removed. Similarly, I'll replicate this suggestion in Android 👍 .

Suggestion applied in fb13609.

derekblank · 2022-12-15T06:55:18Z

It's interesting that this step succeeded in your case. Following the above comment, due to the fact that the RN bundle wasn't updated, the Jetpack blocks shouldn't have been displayed as unsupported since this was a new change 🤔.

Actually, this particular case makes sense -- I was running both local and installable builds when testing. When running locally I was pointing at the Gutenberg Mobile branch, so I was able to pick up the Gutenberg Mobile changes, not realizing they could have different results. However, now I am wondering why the other step, Observe that the section Get support is NOT present. 🔴 was also failing for me locally, while succeeding for you. I ran through the testing steps multiple times on different Simulator devices (as I only have one physical iOS testing device), so it is possible I was mixing feedback from local and installable build testing when doing various testing runs. This is especially possible as at the time I was not feeling well while testing this. 😓 Either way, I am retesting the installable builds with the updated bundle. 👍

derekblank

After retesting the installable builds with the updated bundle, I was able to succeed on every step of the testing criteria. 🟢

LGTM! 🚀

hassaanelgarem

LGTM! 🚀

geriux

All tests passed correctly ✅

fluiddot added the Gutenberg Editing and display of Gutenberg blocks. label Nov 30, 2022

fluiddot added this to the 21.5 milestone Nov 30, 2022

fluiddot self-assigned this Nov 30, 2022

fluiddot mentioned this pull request Dec 2, 2022

Only register core blocks when onlyCoreBlocks capability is enabled wordpress-mobile/gutenberg-mobile#5293

Merged

2 tasks

fluiddot force-pushed the gutenberg/disable-jp-editor-features branch from e47c3d8 to e6479b8 Compare December 12, 2022 15:54

fluiddot marked this pull request as ready for review December 12, 2022 15:54

fluiddot added the [Status] DO NOT MERGE label Dec 12, 2022

fluiddot force-pushed the gutenberg/disable-jp-editor-features branch from e6479b8 to 677e26c Compare December 12, 2022 16:22

hassaanelgarem reviewed Dec 14, 2022

View reviewed changes

derekblank self-requested a review December 15, 2022 08:17

derekblank approved these changes Dec 15, 2022

View reviewed changes

fluiddot mentioned this pull request Dec 15, 2022

[Gutenberg] Disable editor Jetpack-powered features based on Jetpack Features Removal phases wordpress-mobile/WordPress-Android#17587

Merged

3 tasks

fluiddot requested review from hassaanelgarem and geriux December 16, 2022 19:30

hassaanelgarem approved these changes Dec 18, 2022

View reviewed changes

fluiddot added 4 commits December 27, 2022 16:34

Disable editor features via Gutenberg capabilities

fdcdedd

Use different help title depending on removal phase

d83bda5

Add helper to determine when Jetpack features should be removed

452b01d

Update Gutenberg Mobile ref

74d38a6

fluiddot force-pushed the gutenberg/disable-jp-editor-features branch from a38f060 to 74d38a6 Compare December 27, 2022 15:53

geriux approved these changes Dec 29, 2022

View reviewed changes

fluiddot added 2 commits December 29, 2022 19:42

Merge branch 'trunk' into gutenberg/disable-jp-editor-features

510417b

Update Gutenberg Mobile ref with tag

2788fa5

fluiddot removed the [Status] DO NOT MERGE label Dec 29, 2022

fluiddot merged commit 5d8d084 into trunk Dec 30, 2022

fluiddot deleted the gutenberg/disable-jp-editor-features branch December 30, 2022 09:10

fluiddot mentioned this pull request Dec 30, 2022

Jetpack Focus: Remove Jetpack features during phase 4 #19816

Merged

4 tasks

This was referenced Feb 8, 2023

[Support Forum] Hide Gutenberg support section #20101

Closed

Update entry points to Help & Support #19979

Closed

fluiddot mentioned this pull request Mar 9, 2023

[Gutenberg] Allow audio upload to premium users after Jetpack features removal #20291

Merged

4 tasks

hassaanelgarem mentioned this pull request Mar 15, 2023

Jetpack Focus: Introduce new Static Screens phase #20331

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gutenberg] Disable editor Jetpack-powered features based on Jetpack Features Removal phases #19691

[Gutenberg] Disable editor Jetpack-powered features based on Jetpack Features Removal phases #19691

fluiddot commented Nov 30, 2022 •

edited

Loading

wpmobilebot commented Dec 7, 2022 •

edited

Loading

wpmobilebot commented Dec 7, 2022 •

edited

Loading

derekblank commented Dec 13, 2022

fluiddot commented Dec 13, 2022

fluiddot commented Dec 13, 2022

hassaanelgarem Dec 14, 2022

fluiddot Dec 14, 2022

fluiddot Dec 16, 2022

derekblank commented Dec 15, 2022 •

edited

Loading

derekblank left a comment

hassaanelgarem left a comment •

edited

Loading

geriux left a comment

[Gutenberg] Disable editor Jetpack-powered features based on Jetpack Features Removal phases #19691

[Gutenberg] Disable editor Jetpack-powered features based on Jetpack Features Removal phases #19691

Conversation

fluiddot commented Nov 30, 2022 • edited Loading

To test

1 - Editor Jetpack-powered features ENABLED in WordPress app

Preparation

Check Jetpack blocks

Check @-mentions and X-posts features

Check the help's support section

Check Reusable blocks

Check Unsupported Block Editor (UBE)

2 - Editor Jetpack-powered features DISABLED in WordPress app

Preparation

Check Jetpack blocks

Check @-mentions and X-posts features

Check the help's support section

Check Reusable blocks

Check Unsupported Block Editor (UBE)

3- Editor Jetpack-powered features ENABLED in Jetpack app

Regression Notes

wpmobilebot commented Dec 7, 2022 • edited Loading

wpmobilebot commented Dec 7, 2022 • edited Loading

derekblank commented Dec 13, 2022

fluiddot commented Dec 13, 2022

fluiddot commented Dec 13, 2022

hassaanelgarem Dec 14, 2022

Choose a reason for hiding this comment

fluiddot Dec 14, 2022

Choose a reason for hiding this comment

fluiddot Dec 16, 2022

Choose a reason for hiding this comment

derekblank commented Dec 15, 2022 • edited Loading

derekblank left a comment

Choose a reason for hiding this comment

hassaanelgarem left a comment • edited Loading

Choose a reason for hiding this comment

geriux left a comment

Choose a reason for hiding this comment

fluiddot commented Nov 30, 2022 •

edited

Loading

wpmobilebot commented Dec 7, 2022 •

edited

Loading

wpmobilebot commented Dec 7, 2022 •

edited

Loading

derekblank commented Dec 15, 2022 •

edited

Loading

hassaanelgarem left a comment •

edited

Loading