Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Focus: Introduce new Static Screens phase #20331

Merged

Conversation

hassaanelgarem
Copy link
Contributor

Closes #20329

Description

This PR introduces a new "Static Screens" phase. Some aspects of the phase are implemented, but the main tasks of showing static screens in Stats, Reader, and Notifications are yet to come.

Testing Instructions

  1. Install the WordPress app
  2. From the debug menu, enable the "Jetpack Features Removal Static Screens Phase" feature flag
  3. Go back to My Site
  4. Close and reopen the app
  5. Make sure that the dashboard is not available
  6. Make sure that the tab bar is available and Stats, Reader, and Notifications are accessible
  7. Make sure that Sub-features like Activity Log are accessible
  8. Make sure that no cards are added to the menu
  9. Try creating a site, make sure that the flow is disabled and you're shown an overlay pointing to the Jetpack app
  10. Add a Stats widget to your home screen
  11. Tap the widget
  12. Make sure the app opens, but an overlay is not displayed
  13. Open the editor, and make sure that JP-powered blocks are not available (Check [Gutenberg] Disable editor Jetpack-powered features based on Jetpack Features Removal phases #19691 for a full list)

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 15, 2023

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20331-bff2237 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@dvdchr
Copy link
Contributor

dvdchr commented Mar 16, 2023

The CI build failed. Rebuilding...

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 16, 2023

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20331-bff2237 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified that it works as described. LGTM! :shipit:

@hassaanelgarem hassaanelgarem changed the base branch from trunk to release/21.9 March 16, 2023 11:31
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@hassaanelgarem hassaanelgarem merged commit d9118c3 into release/21.9 Mar 16, 2023
@hassaanelgarem hassaanelgarem deleted the task/20329-rethinked-disabled-state-helpers branch March 16, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS - Add helpers to identify the new disabled state
4 participants