Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Ruby 3 RuboCop violations #21541

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Sep 11, 2023

17ec957 (#21498) switched the expected Ruby version to 3.x (🎉)

Our Ruby linting automation only runs on diffed files so it didn't catch new violations that arose from the migration. The only reason I noticed, actually was because I just happened to modify the Podfile in df0aa0bd25a3cf4fa6313eb3534bd05c959a2a8 (#21344) and got a CI failure. I based this PR off #21344 because I had to fix one of the issues there in order for the linter to pass.

To test: checkout the branch and verify RuboCop doesn't find new violations:
image

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

@mokagio mokagio requested a review from crazytonyli September 11, 2023 04:29
@mokagio mokagio force-pushed the mokagio/remove-google-sdk branch from 53004bb to 523b3f2 Compare September 11, 2023 04:29
@mokagio mokagio force-pushed the mokagio/rubocop-3-violations branch from 180a4f8 to 1c8ffba Compare September 11, 2023 04:30
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 11, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21541-57473ab
Version23.2
Bundle IDorg.wordpress.alpha
Commit57473ab
App Center BuildWPiOS - One-Offs #7090
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 11, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21541-57473ab
Version23.2
Bundle IDcom.jetpack.alpha
Commit57473ab
App Center Buildjetpack-installable-builds #6133
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio added this to the 23.3 milestone Sep 12, 2023
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Sep 12, 2023
@mokagio mokagio force-pushed the mokagio/remove-google-sdk branch from 8941b1b to 1748d8e Compare September 13, 2023 04:05
Base automatically changed from mokagio/remove-google-sdk to trunk September 13, 2023 22:48
17ec957 (#21498) switched the expected
Ruby version to 3.x (🎉)

Our Ruby linting automation only runs on diffed files so it didn't catch
new violations that arose from the migration. The only reason I noticed,
actually was because I just happened to modify the `Podfile` in
8df0aa0 (#21344) and got a CI failure.
@mokagio mokagio force-pushed the mokagio/rubocop-3-violations branch from 1c8ffba to 57473ab Compare September 15, 2023 01:58
@mokagio mokagio enabled auto-merge September 15, 2023 01:58
@mokagio mokagio merged commit c26c27d into trunk Sep 15, 2023
@mokagio mokagio deleted the mokagio/rubocop-3-violations branch September 15, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants