Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when interacting with RichText (caused by Gutenberg #19117) #1693

Closed
mchowning opened this issue Dec 17, 2019 · 1 comment
Closed

Crash when interacting with RichText (caused by Gutenberg #19117) #1693

mchowning opened this issue Dec 17, 2019 · 1 comment
Assignees
@mchowning
Labels
[Type] Crash [Type] Regression Existing functionality that got broken Web breakage Caused by incompatible changes on Gutenberg web

Comments

@mchowning
Copy link
Contributor

mchowning commented Dec 17, 2019 •
edited
Loading

Describe the bug

Tapping on any RichText component results in the following javascript crash:

TypeError: undefined is not an object (evaluating formatTypes.map)

This is due to a recent gutenberg change that now requires formatTypes to be passed to the FormatEdit component as a prop.

To Reproduce

Steps to reproduce the behavior:

  1. Tap on any RichText-based block (paragraph, heading, etc.)
  2. Observe crash because formatTypes is undefined
@mchowning mchowning self-assigned this Dec 17, 2019
@mchowning mchowning added [Type] Crash [Type] Regression Existing functionality that got broken Web breakage Caused by incompatible changes on Gutenberg web labels Dec 17, 2019
@mchowning mchowning mentioned this issue Dec 17, 2019
Merged
6 tasks
@hypest hypest mentioned this issue Dec 17, 2019
Merged
6 tasks
@hypest
Copy link
Contributor

hypest commented Jun 11, 2020

Fixed with WordPress/gutenberg#19200

@hypest hypest closed this as completed Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchowning mchowning

Labels
[Type] Crash [Type] Regression Existing functionality that got broken Web breakage Caused by incompatible changes on Gutenberg web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hypest @mchowning