Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNMobile: Pass formatTypes to FormatEdit component #19200

Merged
merged 1 commit into from
Dec 17, 2019
Merged

RNMobile: Pass formatTypes to FormatEdit component #19200

merged 1 commit into from
Dec 17, 2019

Conversation

mchowning
Copy link
Contributor

Description

Fixes a recently introduced crash that occurred because FormatEdit now requires a formatTypes prop, but we were not passing that prop on mobile.

relevant Gutenberg-Mobile issue

To Test

You can use this seemingly unrelated gutenberg-mobile PR to test this. It's gutenberg ref has been updated to point at this PR. Or you can test using 'develop` and pointing to this branch.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

cameronvoell
cameronvoell approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified we no longer crash when selecting a paragraph block. Smoke tests around copy, paste, etc, look good as well. LGTM!

@ellatrix
Copy link
Member

Thanks!

@mchowning mchowning merged commit 7a337cf into master Dec 17, 2019
@mchowning mchowning deleted the rnmobile/1693_fix_format_types_undefined_crash branch December 17, 2019 20:06
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
@hypest hypest mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

@hypest hypest Awaiting requested review from hypest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 7.2
Development

Successfully merging this pull request may close these issues.
4 participants
@mchowning @ellatrix @cameronvoell @youknowriad