Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote block #207

Closed
koke opened this issue Oct 29, 2018 · 3 comments · Fixed by #1067 or #1082
Closed

Quote block #207

koke opened this issue Oct 29, 2018 · 3 comments · Fixed by #1067 or #1082
Assignees
Labels
Milestone

Comments

@koke
Copy link
Member

koke commented Oct 29, 2018

Add support for the quote block.

What we're not implementing in the beta:

  • Text alignment
  • Inspector settings: text size and color
  • Quote styles. Not specific to quotes, we might need block transformations first.
@koke koke added this to the Beta milestone Oct 29, 2018
@koke
Copy link
Member Author

koke commented Nov 6, 2018

From @daniloercoli:

I did some research and guess we can tackle this block in a couple of days, even though it could be necessary to make some changes to AztecWrapper. 1 week from start to end to be on the safe side.

Estimating 1 week per platform

@etoledom etoledom self-assigned this Jan 15, 2019
@etoledom etoledom removed their assignment Jan 17, 2019
@Tug Tug self-assigned this Apr 18, 2019
@koke koke unassigned Tug May 6, 2019
@SergioEstevao
Copy link
Contributor

@iamthomasbishop here is a screenshot with the current state of quotes:

Simulator Screen Shot - iPhone Xʀ - 2019-06-03 at 10 31 42

@iamthomasbishop
Copy link
Contributor

This is looking really close already, great work @SergioEstevao ! I apologize for not having the specs in the Zeplin project earlier – I 100% thought they were already in there! There are a couple of tiny things that jump out at me:

  • There should be a small space between the quote and citation – 16pt

  • The citation font-size should be slightly smaller – 14pt

For visual reference:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment