Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/207 quotes design review #1067

Merged
merged 9 commits into from
Jun 5, 2019
Merged

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jun 4, 2019

Fixes #207

Related GB PR: WordPress/gutenberg#15990

This PR addresses the design review made in #207. It changes the following:

  • Spaces quote and citation by 16px
  • Make the citation font size to be 14px

Here is the end result:

Simulator Screen Shot - iPhone Xʀ - 2019-06-04 at 22 36 29

To test:

  • Run the demo app
  • Check that the quotes styles is correct.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added the [Status] Needs Design Review Needs design review or sign-off before shipping label Jun 4, 2019
@SergioEstevao SergioEstevao added this to the v1.7 milestone Jun 4, 2019
@iamthomasbishop
Copy link
Contributor

iamthomasbishop commented Jun 4, 2019

Thanks for jumping on those changes! Looking great. I just noticed something that I should've noticed in the first review. There appears to be a small gap on the left side of the Quote divider line. I'm unsure if this is because of something in this quote work, or related to this issue (I am also seeing this spacing on an Android build that @hypest just sent me).

image

@SergioEstevao
Copy link
Contributor Author

@iamthomasbishop sorted the margin issue, here is the end result:
Simulator Screen Shot - iPhone Xʀ - 2019-06-04 at 23 08 33

@iamthomasbishop
Copy link
Contributor

Very interesting optical illusion going on here. It looks like it's like 2-4px left of aligned, but mathematically it's "proper" :) It's easier to see it's aligned w/ an alignment guide, for example:

image

But when you remove the guide, it optically feels slightly left of where it should be. For now, let's keep it simple and leave it how you have it right now – we can always adjust it if we want to align optically, but this sets it to the mathematical baseline.

Thank you!

@SergioEstevao SergioEstevao merged commit b9e9ce1 into develop Jun 5, 2019
@SergioEstevao SergioEstevao deleted the issue/207_quotes_design_review branch June 5, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Design Review Needs design review or sign-off before shipping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quote block
3 participants