-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quotes: Fix handling of insertion and removal of empty lines. #1082
Conversation
I tried this:
|
Ok, I had not realized I had to update Aztec for testing, the previous case works well. I found a new issue, but I don't think we need to block on this one, we can handle it separately:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this and it works fine, although I'm not sure I understand the code changes well enough, you might want a second set of eyes on those.
Fixes #207
Relate GB PR: WordPress/gutenberg#16013
This PR fixes the following issues around the insertion and removal of empty lines inside quotes:
The main changes are the following:
<p></p>
isn't remove by AztecTo test:
Know issues :
I know the issues above are not ideal, but I think they are better than having the crash on removal, or not having the possibility of adding multiple empty lines inside the quote.
Update release notes:
RELEASE-NOTES.txt
.