Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code to use the new OnSplit prop on RichText. #1013

Merged
merged 6 commits into from
May 22, 2019
Merged

Update code to use the new OnSplit prop on RichText. #1013

merged 6 commits into from
May 22, 2019

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented May 21, 2019 •
edited
Loading

This PR updates the GB reference to use a version that uses the new onSplit method for the RichText component.

Relate GB PR: WordPress/gutenberg#15762

To test:

  • Test splits, merges and pastes on the following blocks:
  • Paragraph, Heading and Lists

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added the [Type] Bug Something isn't working label May 21, 2019
@SergioEstevao SergioEstevao added this to the v1.6 milestone May 21, 2019
@SergioEstevao SergioEstevao requested a review from Tug May 21, 2019 21:07
@SergioEstevao SergioEstevao mentioned this pull request May 21, 2019
Merged
5 tasks
@mkevins mkevins mentioned this pull request May 22, 2019
Closed
Tug
Tug approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SergioEstevao SergioEstevao merged commit d4f9614 into develop May 22, 2019
@SergioEstevao SergioEstevao deleted the issue/update_on_split_uses branch May 22, 2019 22:26
@koke koke mentioned this pull request May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tug Tug Tug approved these changes

Assignees

@SergioEstevao SergioEstevao

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioEstevao @Tug