Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native-svg version #1210

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Conversation

jtreanor
Copy link
Contributor

@jtreanor jtreanor commented Jul 9, 2019

This updates the react-native-svg hash to include the fix from wordpress-mobile/react-native-svg#5 (should be merged first). It ensures pod install doesn't use an old, cached version of 9.3.3.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@jtreanor jtreanor requested a review from etoledom July 9, 2019 10:46
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Tested with the demo app and updating the gutenberg-mobile commit ref from wordpress-mobile/WordPress-iOS#12056:
Installing RNSVG 9.3.3-gb (was 9.3.3)

@jtreanor jtreanor merged commit 9db88d4 into issue/android_x_migration Jul 9, 2019
@SergioEstevao SergioEstevao deleted the update/RNSVG branch January 14, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants