-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce grouping in the block settings inspector #1397
Merged
lukewalczak
merged 17 commits into
develop
from
callstack/rnmobile/grouping-block-settings
Oct 18, 2019
Merged
Introduce grouping in the block settings inspector #1397
lukewalczak
merged 17 commits into
develop
from
callstack/rnmobile/grouping-block-settings
Oct 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
pinarol
added
the
[Status] Needs Design Review
Needs design review or sign-off before shipping
label
Oct 2, 2019
I gave a thorough design review over here. Let me know if I missed anything or when another review is needed! |
…rg-mobile into callstack/rnmobile/grouping-block-settings
…rg-mobile into callstack/rnmobile/grouping-block-settings
pinarol
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
koke
approved these changes
Oct 18, 2019
daniloercoli
added a commit
that referenced
this pull request
Oct 21, 2019
…rg-mobile into issue/wp-android-8828-Aztec-crash-Android-8 * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (24 commits) Feat: cover cross platform RangeControl (#1342) Introduce grouping in the block settings inspector (#1397) Fix native test of image block (#1456) Update RELEASE notes with iOS11 and Swift 5 update Expose WordPressUtils for consumption by gutenberg-bridge Update Aztec-Android ref to v1.3.33 Update bundles revert missing toggle editor mode call (#1444) Update Aztec-iOS ref to 1.11.0 Update Aztec-Android ref to v1.3.32 Update Aztec-iOS ref Update bundles Bump version to 1.15.0 Update Gutenberg Add Media & Text block to initial HTML Update Gutenberg Updated bundles Update Gutenberg Update Gutenberg Update gutenberg ... # Conflicts: # react-native-aztec/android/build.gradle
daniloercoli
added a commit
that referenced
this pull request
Oct 23, 2019
…rg-mobile into issue/wp-android-9832-IndexOutOfBoundsException-setSpan * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: Bump version to 1.15.1 Update bundles Update Aztec to the new tagged version v1.3.34 Feat: cover cross platform RangeControl (#1342) Introduce grouping in the block settings inspector (#1397) Fix native test of image block (#1456) # Conflicts: # react-native-aztec/android/build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1384
Ref to gutenberg: WordPress/gutenberg#17703
To test:
BlockSettings
inspectorUpdate release notes:
RELEASE-NOTES.txt
.