Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Scroll position android #1478

Merged
merged 7 commits into from
Oct 28, 2019
Merged

[FIX] Scroll position android #1478

merged 7 commits into from
Oct 28, 2019
+103 −103

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Oct 22, 2019

Fixes #1474
Gutenberg PR - WordPress/gutenberg#18060
To test:

  • In the android app, focus the first editable field you can find (example: the "What is Gutenberg?" heading block
  • Scroll down, trying to reach the end of the content
  • Wait and check if you still see the end of content (scroll position should not move up)

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@dratwas dratwas mentioned this pull request Oct 22, 2019
Merged
5 tasks
@pinarol pinarol requested a review from marecar3 October 22, 2019 14:13
@pinarol pinarol added the [Type] Bug Something isn't working label Oct 22, 2019
@pinarol pinarol added this to the 1.16 milestone Oct 22, 2019
marecar3
marecar3 approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Nice work @dratwas !

@pinarol pinarol modified the milestones: 1.16, 1.15.2 Oct 28, 2019
@dratwas dratwas changed the base branch from develop to release/1.15.2 October 28, 2019 10:44
@pinarol pinarol merged commit 1811d84 into release/1.15.2 Oct 28, 2019
@pinarol pinarol deleted the fix/scroll-position branch October 28, 2019 10:56
This was referenced Oct 28, 2019
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

Assignees

@dratwas dratwas

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
1.15.2
Development

Successfully merging this pull request may close these issues.
6 participants
@dratwas @marecar3 @pinarol @lukewalczak @cameronvoell @jbinda