Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/1592 fix alignment hiding image placeholder #1631

Merged
merged 2 commits into from
Dec 17, 2019

Conversation

mchowning
Copy link
Contributor

Fixes #1592

This fixes a bug that was introduced with the addition of paragraph alignment options. In particular, the placeholder icon would not display for an aligned image block if the image could not be downloaded.

Related gutenberg PR

To test:

  • Create a draft post on web with aligned images
  • Open an empty post in the app (to load the js from the metro bundler)
  • Go to the list of draft posts in the app so that the newly created draft is loaded
  • Turn on airplane mode
  • Open the draft post
  • Observe that all of the image blocks have visible placeholder images

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,3 +1,7 @@
1.19.0
------
* Fix bug where image placeholders would sometimes not be shown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go to 1.20.0.

@mchowning mchowning force-pushed the issue/1592_fix_alignment_hiding_image_placeholder branch from cca4d08 to 7df54fd Compare December 17, 2019 20:08
@mchowning mchowning merged commit b3c48b0 into develop Dec 17, 2019
@mchowning mchowning deleted the issue/1592_fix_alignment_hiding_image_placeholder branch December 17, 2019 21:16
@designsimply
Copy link
Contributor

LGTM! (here is a screenshot from beta testing)

Screenshot_20200114-154305

Tested with WPAndroid 14.0-rc-1 on Pixel 3 Android 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images with alignment do not show up in the editor when editing offline
4 participants