Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove left border of the toolbar #2004

Merged
merged 4 commits into from
May 11, 2020
Merged

Remove left border of the toolbar #2004

merged 4 commits into from
May 11, 2020

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Mar 12, 2020 •
edited
Loading

Targets gutenberg PR WordPress/gutenberg#20830

To test:

  • Checkout this branch
  • Boot the app on android and iOS
  • Check that the left border of the bottom toolbar is not visible anymore
  • Check that the block toolbar (visible when you edit a block with richtext) is displayed properly

image

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Tug Tug self-assigned this Mar 12, 2020
@Tug Tug mentioned this pull request Mar 12, 2020
Merged
6 tasks
@Tug Tug force-pushed the remove/header-toolbar-left-border branch from 716df32 to e1387ea Compare March 12, 2020 13:30
iamthomasbishop
iamthomasbishop reviewed Mar 12, 2020
View reviewed changes
Copy link
Contributor

@iamthomasbishop iamthomasbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tug I assume that the only visual change is to remove the border, but would you mind adding a screenshot so I can review visually?

@iamthomasbishop
Copy link
Contributor

@Tug Never mind, just saw the screenshots on the other ticket 🤦‍♂

etoledom
etoledom approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#20830 (review)

SergioEstevao
SergioEstevao approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hypest hypest mentioned this pull request Mar 17, 2020
Closed
2 tasks
@SergioEstevao SergioEstevao linked an issue May 4, 2020 that may be closed by this pull request
Remove border-left from Quick Toolbar #639
Closed
@SergioEstevao SergioEstevao added this to the 1.28 milestone May 11, 2020
@SergioEstevao SergioEstevao merged commit a012e12 into develop May 11, 2020
@SergioEstevao SergioEstevao deleted the remove/header-toolbar-left-border branch May 11, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamthomasbishop iamthomasbishop iamthomasbishop left review comments

@etoledom etoledom etoledom approved these changes

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees

@Tug Tug

Labels
None yet
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.

Remove border-left from Quick Toolbar
4 participants
@Tug @iamthomasbishop @SergioEstevao @etoledom