Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the border-left from the toolbar #2017

Closed

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Mar 13, 2020

Fixes #639

Gutenberg side PR: WordPress/gutenberg#20881

With the left border Without the left border
Screenshot 2020-03-13 at 17 01 35 Screenshot 2020-03-13 at 17 01 10

To test:

  1. Run the demo app and capture a screenshot of the app
  2. Notice that there is no 1-pixel grey border to the left of the Inserter button

cc @iamthomasbishop in case you also want to try this out.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest added this to the 1.24 milestone Mar 13, 2020
@hypest hypest requested a review from cameronvoell March 13, 2020 15:00
@hypest hypest changed the title Update Gutenberg ref Remove the border-left from the toolbar Mar 13, 2020
@marecar3
Copy link
Contributor

We're freezing 1.24.0 today. If you think it is ready and if you'd like to ship it with 1.24.0please merge it into develop branch. Otherwise, we can bump it to 1.25.0. @hypest @cameronvoell

@hypest hypest modified the milestones: 1.24, 1.25 Mar 17, 2020
@hypest
Copy link
Contributor Author

hypest commented Mar 17, 2020

Moved to 1.25, although this PR will probably get closed in favor of #2004

@SergioEstevao
Copy link
Contributor

@hypest I'm moving this to 1.26, feel free to move it back to 1.25 if this is something that can be considered a regression.

@SergioEstevao SergioEstevao modified the milestones: 1.25, 1.26 Mar 31, 2020
@pinarol pinarol modified the milestones: 1.26, 1.27 Apr 13, 2020
@pinarol
Copy link
Contributor

pinarol commented Apr 13, 2020

I am changing the milestone of this PR as 1.27 because the 1.26 release branch will be cut quite soon. Let me know if you instead wanted to include this to 1.26.

@mkevins
Copy link
Contributor

mkevins commented Apr 27, 2020

Hi @hypest wave smiley since this one is still awaiting review (and will possibly be superseded), I'll bump the milestone to 1.28. Please let me know if you wanted to get this into the 1.27 release.

@mkevins mkevins modified the milestones: 1.27, 1.28 Apr 27, 2020
@SergioEstevao
Copy link
Contributor

@hypest do you still want to have this on 1.28 ?

@SergioEstevao
Copy link
Contributor

I think this other PR solved the original issue.

Do you want to close this one @hypest ?

@hypest
Copy link
Contributor Author

hypest commented May 11, 2020

Will close this one to remove the confusion. Was waiting for #2004 to land first before closing but yeah, no real need to postpone.

@hypest hypest closed this May 11, 2020
@hypest hypest deleted the issue/639-hide-left-border-of-inserter-toolbargroup branch May 11, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove border-left from Quick Toolbar
5 participants