Image block - Update image url #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
# Conflicts: # gutenberg
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WordPress/gutenberg#25418
Gutenberg PR-> WordPress/gutenberg#25529An issue was reported of the Image block not keeping its image size after duplicating, after some investigation it turns out that if the block is not selected while an upload is in process it won't request the image data, sizes, and resized URL when it finishes.
On the web editor, it works differently because when the post request is made to upload the image it returns the resized URL and data, where in mobile it just returns the full size URL of the image.
This PR handles the case of updating the final resized URL of the image when the block is not selected and there's an ongoing upload.
To test check the Gutenberg PR description.
PR submission checklist: