Release 1.38.0

[cameronvoell]

Release for Gutenberg Mobile 1.38.0

Related PRs

• Gutenberg: Mobile Release v1.38.0 WordPress/gutenberg#25686
• WPAndroid: Integrate gutenberg-mobile release 1.38.0 WordPress-Android#13023
• WPiOS: Integrate gutenberg-mobile release 1.38.0 WordPress-iOS#15008

Extra PRs that Landed After the Release Was Cut

• Correct BottomSheet in ModalLinkUI: [RNMobile] Rotation Fix - correct BottomSheet in ModalLinkUI WordPress/gutenberg#25740
• Fix color palette scroll within Cover placeholder: [RNMobile] Fix color palette scroll within Cover placeholder WordPress/gutenberg#25734

Changes

• Fix Buttons block text input: Fix Buttons block text input #2665
• Image Block - Update image url: Image block - Update image url  #2652
• Improve AztecWrapper RN Talkback support: Improve AztecWrapper RN talkback support #2630
• MediaUpload - Remove dashincons and use icons instead: MediaUpload - Remove dashicons and use icons instead #2660
• Link picker via fetch: Link picker via fetch #2484
• Media Editing - show button for invalid images: Media editing - Show button for invalid images #2623
• Increase tap-target of primary action on unsupported Blocks: Increase tap-target of primary action on unsupported blocks #2608
• Update target and compile Android sdk versions to v29: Update target and compile Android sdk versions to v29 WordPress/gutenberg#25488

Aztec Android:

• Change the license from GPL v2 to MPL v2: Change the license from GPL v2 to MPL v2 AztecEditor-Android#922
• Fix parentStyle must not be null: Fix parentStyle must not be null AztecEditor-Android#923
• Fix drag shadow dimensions crash: Fix drag shadow dimensions crash AztecEditor-Android#924
• Account for the end of buffer marker: [Gutenberg] Account for the end of buffer marker AztecEditor-Android#928
• Accessibility Improvement: Remove focusing of AztecText control as it's unneeded in TalkBack mode: Accessibility Improvement : Remove focusing of AztecText control as it's unneeded in TalkBack mode. AztecEditor-Android#927

Test plan

• Use the main WP apps to test the changes above.
• Smoke test the main WP apps for general writing flow.

Release Submission Checklist

• Approve and run optional Android and iOS UI tests
• Aztec dependencies are pointing to a stable release.
  • iOS: Aztec dependencies match in RNTAztecView.podspec and gutenberg/packages/react-native-aztec/RNTAztecView.podspec.
• Gutenberg 'Podfile.lock' inside 'gutenberg/package/react-native-editor/ios/' is updated to the release number.
• Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
• Bundle package of the release is updated.

[pinarol]

Testing with WPiOS

Gallery-2

• Gallery block - Insert image from device (failing) - steps
• Gallery block - Insert image from device (cancel) - steps

Gallery-4

• Gallery block - Settings: Link to - steps
• Gallery block - Settings: Column number - steps
• Gallery block - Settings: Crop images - steps

Columns - 2

• Columns - Max limit of Column number - steps
• Columns - Min limit of Column number - steps
• Columns - Removing Column with remove button - steps
• Columns - Removing the only one left Column with remove button - steps
• Columns - Changing alignment on Columns - steps
• Columns - Changing alignment on individual Columnn - steps
• Columns - Alignment attribute is properly passed when adding Column - steps
• Columns - Deep nesting is possible (iOS only)- steps

Columns - 4

• Columns - Check if in DarkMode all components gets proper colors - steps

MediaText-3

• Media Text block - Insert video from device (failing) - steps
• Media Text block - Close/Re-open post with an ongoing video upload - steps

MediaText-4

• Media Text block - Media & Text alignment - steps
• Media Text block - Vertical alignment - steps

Shortcode-1

• Shortcode block - Add a youtube link - steps

Cover-2

• Cover - Add Video Background from WordPress Media library - steps
• Cover - Replace media - steps
• Cover - Gradient background is rendered properly - steps
• Cover - Gradient overlay is rendered properly - steps

Social Icons - 2

• The link sheet is opened automatically when adding new icon - steps
• Ghost placeholder is visible when no icon is active - steps
• Social icon forwarding to the link - steps

[dratwas]

Testing with WPAndroid

DarkMode-2

• Spacer block - Dark mode - steps
• Buttons block - Dark mode - steps
• Group - Dark mode - steps
• Columns - Dark mode - steps

Group-2

• Group - Navigation up button works as expected - steps
• Group - Navigation down works according to parent-first approach - steps
• Group - Cross navigation between blocks works as expected - steps
• Group - Ungroup button works as expected - steps
• Group - Check if in DarkMode all components gets proper colors - steps
• Group - Check if nested Placeholder block can be replaced - steps

Spacer-2

• Spacer block - Settings: Available height range is correct - steps
• Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - steps
• Spacer block - Spacer in horizontal layout works as expected - steps

Button-4

• Buttons block - Render custom text color - steps
• Buttons block - Render custom background color - steps
• Buttons block - Render gradient background color - steps
• Buttons block - Check if selection / caret color matches font color - steps
• Buttons block - The newly created Buttons has set background color to the theme-default color in preview - steps

Button-5

• Buttons block - Edit text styles - steps
• Buttons block - Render theme colors - steps
• Buttons block - Settings: Change Button border radius - steps

Button-7

• Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - steps
• Buttons block - Toolbar link button is active when Button has link - steps

Editor Theme-2

• Custom Gradients - Check that custom gradients load in the editor - steps
• Offline Support - steps

Color Settings-2

• Pressing color swatch - steps
• Customize gradient color - steps
• Custom color picker - steps

[peril-wordpress-mobile]

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

[lukewalczak]

I observed the crash within the cover block when trying to scroll the color palette on the cover placeholder.

Steps to reproduce it:

1. Open a post
2. Add Cover block
3. Try to scroll the color palette on the placeholder
4. Observe the crash

cc: @antonis @pinarol

I opened the issue to track it: #2682

PR fixing that: WordPress/gutenberg#25734

[ceyhun]

Tested with WPiOS Build 35590 on iPhone 11 Pro with iOS 14

Writing Flow checklist:

• TC001 - Block insertion flow
• TC001 - Paste formatted text copied from website
• TC001 - Multiline components
• Rich Text Format
  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
• Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block
• Undo / Redo - Test Cases
  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

I encountered an issue with the first test case of undo/redo where at the last step I couldn't remove again the last block by redoing. I could not reproduce this issue again so marked it as ✅ for now.

[cameronvoell]

Android Tests, Samsung Galaxy S10+, Android 10

Writing Flow checklist:

• TC001 - Block insertion flow
• TC001 - Paste formatted text copied from website
• TC001 - Multiline components
• Rich Text Format
  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
• Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block
• Undo / Redo - Test Cases
  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

[ceyhun]

Tested new changes as well, LGTM!

[designsimply]

I found this in the release notes:

Block Editor: On Jetpack connected sites, Unsupported Block Editor can be enabled via enabling Jetpack SSO setting directly from within the missing block alert.

I searched and found wordpress-mobile/WordPress-Android#12606 but I was wondering why that PR (or a similar one) wasn't mentioned in the release notes?

The best testing steps look like they're in WordPress/gutenberg#24476 but could you also let me know what else would be ideal to test during 15.9 beta testing or is that the best PR to reference?

I have the same question for wordpress-mobile/WordPress-Android#12990.

Note: only the Jetpack SSO part is mentioned in the release notes for 15.9, should the Unsupported Block Editor itself also be called out? What would you like to tell users about it? Please see p2JRYi-53L-p2.

[designsimply]

Okay. Gah. Perhaps ignore most of that last message! I found the proper link to wordpress-mobile/WordPress-Android#13011 in the RELEASE-NOTES.txt file while I was looking at p2JRYi-53L-p2 before (where they are missing). 😬

The final release notes still might need to be modified at p2JRYi-53L-p2 though.