Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Buttons block text input #2665

Merged
merged 5 commits into from
Sep 28, 2020
Merged

Fix Buttons block text input #2665

merged 5 commits into from
Sep 28, 2020

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Sep 24, 2020

Gutenberg PR -> WordPress/gutenberg#25624

This PR fixes and regression introduced by this PR where some props were missing in the RichText component for the Buttons block causing it impossible to type any text in it.

To test check the Gutenberg PR description

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Web breakage Caused by incompatible changes on Gutenberg web label Sep 24, 2020
@geriux geriux added this to the 1.38 milestone Sep 24, 2020
@geriux geriux requested a review from guarani September 24, 2020 14:29
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 24, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@cameronvoell
Copy link
Contributor

@geriux Just reminding that we'll be cutting the 1.38 release branch later in the day Monday 9/28. Please try to get this merged by then or bump the milestone. Thanks much 🙇

Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging before this week's 1.38 release cut per @geriux's request.

@ceyhun ceyhun merged commit a83fa81 into develop Sep 28, 2020
@ceyhun ceyhun deleted the fix/buttons-text branch September 28, 2020 09:56
@cameronvoell cameronvoell mentioned this pull request Sep 29, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web breakage Caused by incompatible changes on Gutenberg web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants