Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notice size overflow #3411

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Fix notice size overflow #3411

merged 3 commits into from
Apr 22, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Apr 22, 2021 •
edited
Loading

gutenberg PR: WordPress/gutenberg#31083

To test:

For testing this, manual code changes are required to test different text sizes. I tested this by modifying the text of the notice that is triggered when copying a block:

  1. Go to this line
  2. Change the text (it would be nice to test with different text sizes like 2/3/4 lines)
  3. Select any block
  4. Tap on the three dots button to open the block actions menu
  5. Tap on "Copy block" (this will display a notice)
  6. Observe that the content of the notice is displayed properly

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot requested a review from geriux April 22, 2021 11:34
@fluiddot fluiddot self-assigned this Apr 22, 2021
@fluiddot fluiddot added the [Type] Bug Something isn't working label Apr 22, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 22, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot mentioned this pull request Apr 22, 2021
Merged
7 tasks
geriux
geriux approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#31083 (review)

@fluiddot fluiddot added this to the 1.52.0 (17.3) milestone Apr 22, 2021
@fluiddot fluiddot enabled auto-merge April 22, 2021 13:28
@fluiddot fluiddot merged commit 9504774 into develop Apr 22, 2021
@fluiddot fluiddot deleted the fix/notice-size-overflow branch April 22, 2021 13:49
@cameronvoell cameronvoell mentioned this pull request Apr 30, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@fluiddot fluiddot

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
1.52.0 (17.3)
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @geriux