Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.52.0 #3441

Merged
merged 148 commits into from
May 1, 2021
Merged

Release 1.52.0 #3441

merged 148 commits into from
May 1, 2021

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Apr 30, 2021

Release for Gutenberg Mobile 1.52.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.
  • Test the Unsupported Block Editor on WP Apps (see steps).
  • Sanity test suites for WP Apps should be completed for each platform.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

jd-alexander and others added 30 commits October 8, 2020 21:10
This commit points to the relevant PR on Gutenberg.
Revert previous update to .gitmodules, so that it points to the correct WordPress repository.
This commit updates the reference to the latest Gutenberg commit.
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 30, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@illusaen illusaen merged commit 90dfb76 into trunk May 1, 2021
@illusaen illusaen deleted the release/1.52.0 branch May 1, 2021 01:04
@chipsnyder
Copy link
Contributor

chipsnyder commented May 3, 2021

Sanity Tests - Android

These were tested on a Pixel 3a running Android 11 using the APK from the Android PR.

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

🟡 Gallery block - Add Gallery Caption - TC003

  • Gallery block - Add Gallery Image Caption - TC04
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - TC019
  • Columns - Columns percentage mechanism - column's slider input - TC020
  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- TC021
  • Columns percentage mechanism - custom percentage values are rendered correctly on frontend- TC022
  • Columns - Multiple slider in columns parent - TC023
  • Columns - Adding Column with AppenderButton - TC003
  • Columns - Adding and removing Column with BottomSheet Stepper control - TC004

Columns - 2

  • Columns - Max limit of Column number - TC005
  • Columns - Min limit of Column number - TC006
  • Columns - Removing Column with remove button - TC007
  • Columns - Removing the only one left Column with remove button - TC008
  • Columns - Changing alignment on Columns - TC009
  • Columns - Changing alignment on individual Column - TC010
  • Columns - Alignment attribute is properly passed when adding Column - TC011

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - TC002
  • Columns - Appearance in vertical device position (vertical layout) - TC013
  • Columns - Appearance in horizontal device position (horizontal layout) - TC014
  • Columns - Mover direction - TC015
  • Columns - Check if Column placeholder is render in nested structure - TC016
  • Columns - Unselected Column placeholder is stretched to content in nested structure- TC017

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device (TC002) - steps
  • Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Change Minimum height in pixels - TC002
  • Cover - Change Background Opacity - TC009
  • Cover - Image focal point is rendered properly - TC003
  • Cover - Custom color is rendered properly - TC004

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - TC001
  • Active icon gets product color - TC002
  • Only active icons are visible when not selected - TC003

✅ Done - No blockers

📓 For the cover block settings, it wasn't clear to me that you can scroll in this list. This isn't a change for this release but it's something I wanted to make note of.

🟡 For Gallery block, the formatting options can end up being hidden.

  1. Create a gallery block with images
  2. Add a captain to an image with a mention @____
  3. Select to captain the gallery
  4. Notice that the formatting options aren't available:
Video
galleryissue.mp4

@enejb
Copy link
Contributor

enejb commented May 3, 2021

iOS Sanity Test Suite 2 + Story Block 1

iOS 14. on iPhone 11 Pro

DarkMode - 1

Note: that enabling just dark mode in the app wasn't enough. I had to enable it on the device.
The background of the editor was still white.

Group - 1

  • Group - AppenderButton is rendered - TC001
  • Group - Deep nesting is possible (iOS only) - TC002
  • Group - Check if Group placeholder is visible for the unselected state - TC003
  • Group - Check if Group placeholder is render in nested structure - TC004
  • Group - Nested block have proper border styling - TC005
  • Group - Nested block have proper margins values - TC006
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC008

Spacer - 1

  • Spacer block - Spacer is rendered without crash - TC001
  • Spacer block - Settings: Control spacer height using the slider - TC002
  • Spacer block - Settings: Control spacer height using the text input - TC003

Buttons-1

  • Buttons block - Buttons block is added with focused Button with gray background color and white text color - TC001
  • Buttons block - Buttons inline appender - TC002
  • Buttons block - Add another Button inside Buttons using inserter - TC003
  • Buttons block - Button's wrapper grows properly - TC023

Buttons-2

  • Buttons block - Removing Button along with Buttons block - TC004
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC005

Buttons-3

  • Buttons block - Wrapping Buttons - TC006
  • Buttons block - Buttons alignment options - TC007

Button-6

  • Buttons block - Settings: Open in new tab - TC011
  • Buttons block - Settings: Link rel - TC012
  • Buttons block - Settings: Link URL - TC010
  • Buttons block - Settings: Remove link - TC014
  • Buttons block - Settings: Synchronize with button options - TC013

Color Settings - 1

  • Colors Segmented Controls - TC001
  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005

Story block - 1

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

@cameronvoell
Copy link
Contributor Author

cameronvoell commented May 4, 2021

Writing Flow Test Results 🟢 (test links)

Tested on Samsung Galaxy Tab S3 running Android 9

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@illusaen
Copy link
Contributor

illusaen commented May 5, 2021

Problem found:

In multiline components test, verse/pullquote citations make a new block when pressing enter. Not sure if this is desired as it mentions that <br/> should separate them in HTML mode even though there is no specific callout for testing the multiline functionality in the citation parts of verse and pullquote.

EDIT: Not a problem as "On citations, pressing Enter at the end of a citation splits the block, but pressing enter in the middle of a citation creates a new line."

Writing Flow checklist

Tested on iPhone 12 Mini, iOS 14.3

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • NOTE: Verse/Pullquote citations make new block when pressing enter.

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@cameronvoell
Copy link
Contributor Author

cameronvoell commented May 6, 2021

UBE test results:

WPAndroid, 🟢, there is one known issue here: #3425
WPiOS, 🟡 : I found an issue with opening the UBE from an atomic site, and created an issue here: #3461

Recommending not blocking the release for the iOS issue since I do not believe it is new in this release. I think we should investigate that on a separate thread without blocking the release. cc @mchowning @guarani

@hypest
Copy link
Contributor

hypest commented May 6, 2021

Recommending not blocking the release for the iOS issue since I do not believe it is new in this release. I think we should investigate that on a separate thread without blocking the release.

Just for visibility, @guarani will have a look at those next week 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.