Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing title for some unsupported blocks #3489

Merged
merged 5 commits into from
May 18, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented May 12, 2021

gutenberg PR: WordPress/gutenberg#31743

To test:
Follow instructions from gutenberg PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the [Type] Bug Something isn't working label May 12, 2021
@fluiddot fluiddot added this to the 1.53.0 (17.4) milestone May 12, 2021
@fluiddot fluiddot self-assigned this May 12, 2021
@fluiddot fluiddot marked this pull request as ready for review May 12, 2021 10:07
@fluiddot fluiddot requested review from ceyhun and guarani May 12, 2021 10:07
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 14, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun
Copy link
Contributor

ceyhun commented May 14, 2021

Hey there @fluiddot 👋 We'll be cutting the 1.53.0 release some time soon today. I'm bumping this PR to 1.54.0 milestone, please let us know if it needs to make it into 1.53.0 instead.

@ceyhun ceyhun modified the milestones: 1.53.0 (17.4), 1.54.0 (17.5) May 14, 2021
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#31743. Gutenberg ref might need an update.

@fluiddot fluiddot modified the milestones: 1.54.0 (17.5), 1.53.1 (17.4) May 18, 2021
@fluiddot fluiddot merged commit ec1e37c into develop May 18, 2021
@fluiddot fluiddot deleted the fix/missing-block-title branch May 18, 2021 17:18
@AmandaRiu AmandaRiu mentioned this pull request May 21, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants