Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.53.1 #3535

Merged
merged 14 commits into from
May 24, 2021
Merged

Release 1.53.1 #3535

merged 14 commits into from
May 24, 2021

Conversation

AmandaRiu
Copy link
Contributor

@AmandaRiu AmandaRiu commented May 21, 2021 •
edited by dcalhoun
Loading

Release for Gutenberg Mobile 1.53.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.
  • Test the Unsupported Block Editor on WP Apps (see steps).
  • Sanity test suites for WP Apps should be completed for each platform.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

This was referenced May 21, 2021
Merged
Merged
Merged
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 21, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun
Copy link
Member

dcalhoun commented May 21, 2021 •
edited
Loading

🟢 iOS Writing Flow checklist (round 1)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun
Copy link
Member

Verified the currently included fixes listed below cause the related bugs to no longer occur on an iPhone SE, iOS 14.4.2, with build 48731 from wordpress-mobile/WordPress-iOS#16554 (comment). 🎉

@dcalhoun
Copy link
Member

dcalhoun commented May 21, 2021 •
edited
Loading

🟡 iOS Unsupported Block Editor Tests (round 1)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported blocks on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
    🟡 TC004 encountered a variant of a preexisting issue, captured in Editing unsupported blocks is disabled on Jetpack and Atomic sites accessed via older WP.com accounts #3425 (comment).
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites accessed via their own username and password

@dcalhoun dcalhoun mentioned this pull request May 21, 2021
Closed
@AmandaRiu
Copy link
Contributor Author

AmandaRiu commented May 21, 2021 •
edited
Loading

🔁 Android Writing Flow Checklist

Writing Flow checklist

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@AmandaRiu
Copy link
Contributor Author

AmandaRiu commented May 21, 2021 •
edited
Loading

🔁 Android Unsupported Block Editor Tests

  • Pixel 4
  • Android 11
  • pending
  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported blocks on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites accessed via their own username and password

@AmandaRiu AmandaRiu requested a review from dcalhoun May 22, 2021 04:47
@AmandaRiu AmandaRiu marked this pull request as ready for review May 22, 2021 04:47
dcalhoun
dcalhoun approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hopefully we can successfully create an Android build soon to verify the changes before merging.

@dcalhoun dcalhoun added this to the 1.53.1 (17.4) milestone May 24, 2021
@AmandaRiu
Copy link
Contributor Author

AmandaRiu commented May 24, 2021 •
edited
Loading

Verify the following fixes on Android (Pixel 4 - Android 11):

@AmandaRiu AmandaRiu enabled auto-merge May 24, 2021 18:20
@AmandaRiu AmandaRiu merged commit 5a2be1a into trunk May 24, 2021
@AmandaRiu AmandaRiu deleted the release/1.53.1 branch May 24, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
1.53.1 (17.4)
Development

Successfully merging this pull request may close these issues.
3 participants
@AmandaRiu @dcalhoun @fluiddot