Highlight text - Force format for some edge cases #4471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
antonis
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
Thank you for wrangling this @geriux 🙇
Approved via WordPress/gutenberg#37915 (review)
added 2 commits
January 18, 2022 11:50
geriux
force-pushed
the
fix/highlight-text-improvements
branch
from
eece1b4 to
504d1f8
Compare
|
Hey @geriux, we will cut the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some edge cases when applying a highlighted text color format although there are still a few limitations on the native side (Aztec) but for most cases now it should work as expected.
To test check the Gutenberg PR description.
PR submission checklist: